Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 282979 - media-gfx/xli-1.17.0-r3: zoom doesn't work after rebuild with jpeg-7
Summary: media-gfx/xli-1.17.0-r3: zoom doesn't work after rebuild with jpeg-7
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 283241
  Show dependency tree
 
Reported: 2009-08-27 20:37 UTC by Harald van Dijk (RETIRED)
Modified: 2009-09-10 10:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Harald van Dijk (RETIRED) gentoo-dev 2009-08-27 20:37:02 UTC
It ignores any -zoom/-xzoom/-yzoom options, tried with multiple files.

So, broken, without maintainer, without upstream, last snapshot from 2006 (2005 version in portage), ebuild untouched for ages as well. Considering how long it worked without bug reports, I'll wait to see if anyone cares to fix this, but I'm going to guess that if no one steps up, this should be masked for removal...
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2009-08-27 20:52:08 UTC
Adding treecleaners to CC to get some attention for this (it doesn't directly mean it will be removed)
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2009-08-27 21:00:45 UTC
Possible solutions if anyone cares to test:

in $S/jpeg.c, this change:

-length = xli_jpg_getc(cinfo) << 8;
+length = xli_jpg_getc(cinfo) << 16;

and _possible_ also this (it's there 2 times):

-               cinfo.scale_denom = 1 << image_ops->iscale;
+               cinfo.scale_denom *= 1 << image_ops->iscale;
Comment 3 Harald van Dijk (RETIRED) gentoo-dev 2009-08-28 18:23:01 UTC
I don't mind testing if you want to look at this; those two suggestions unfortunately have no effect for me.
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2009-09-04 12:12:43 UTC
matsuu: x11-wm/awesome is using xsetbg and deps on media-gfx/xli, but in fact, media-gfx/xloadimage provides xsetbg as well and isn't broken with jpeg-7...
can you check if that works as alternative?
Comment 5 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-09-05 20:37:54 UTC
I'm working on this now, and I'm finding that xli doesn't zoom on jpegs with jpeg-6 EITHER.

ssuominen:
Your suggestions are completely out. It actually seems to be that with jpeg-7, xli is discarding the zoom settings. I'm going to patch it up shortly.
Comment 6 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-09-05 21:40:22 UTC
jpeg-6:
jpegLoad: image_ops->iscale = 0, cinfo.scale_num/denom = 1/1

jpeg-7: 
jpegLoad: image_ops->iscale = 0, cinfo.scale_num/denom = 8/8

Even with jpeg-6, -iscale and the -zoom options didn't work together, and this is an extension of that problem.
Comment 7 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-09-05 22:21:53 UTC
Fixed in r4 now.