Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 282831 - app-admin/webapp-config-1.50.16-r[13] DeprecationWarning: the md5 module is deprecated; use hashlib
Summary: app-admin/webapp-config-1.50.16-r[13] DeprecationWarning: the md5 module is d...
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Gentoo Web Application Packages Maintainers
URL:
Whiteboard:
Keywords:
: 358357 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-08-26 20:15 UTC by Nico Baggus
Modified: 2013-08-03 14:15 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---
mlspamcb: Bugday?


Attachments
Switch from md5 to hashlib (hashlib.patch,890 bytes, patch)
2009-08-27 02:52 UTC, Robert Trace
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Baggus 2009-08-26 20:15:22 UTC
Since the python-2.6 upgrade this message is given....


Reproducible: Always

Steps to Reproduce:
1.webapp-config -U ......
2.
3.

Actual Results:  
* Upgrading phpldapadmin-1.1.0.5 to phpldapadmin-1.2.0
*   Installed by root on 2008-06-10 01:11:28
*   Config files owned by 0:0
/usr/lib/python2.6/site-packages/WebappConfig/content.py:27: DeprecationWarning: the md5 module is deprecated; use hashlib instead
  import md5, re, os, os.path
!time config/config.php
!time htdocs/index.php
!empty templates
!empty config
!empty htdocs
!empty /var/www/data/cgi-bin
--- /var/www/data/htdocs/phpldapadmin
* Invalid line "" removed from the database file!
*   Creating required directories
*   Linking in required files
*     This can take several minutes for larger apps
^o^ hiding /config/config.php
*   Files and directories installed
* One or more files have been config protected
* To complete your install, you need to run the following command(s):
*
* CONFIG_PROTECT="/var/www/data/htdocs/phpldapadmin//config" etc-update
*
* Install completed - success


Expected Results:  
Same without the deprecation warning.
Comment 1 Robert Trace 2009-08-27 02:52:31 UTC
Created attachment 202368 [details, diff]
Switch from md5 to hashlib

As noted above, python 2.6 (earlier?) deprecated md5 in favor of hashlib and it's being vocal about it.  Conversion to hashlib is easy, so here's a trivial little patch to speed along the upgrade.
Comment 2 Hugo Mildenberger 2009-11-14 17:07:51 UTC
(In reply to comment #1)
I tested your patch with python-2.6.3 and webapp-config-1.50.16-r3, it works ok. Rests one deprecated warning, which isn't covered by your patch:

usr/lib/python2.6/site-packages/WebappConfig/ebuild.py:135: DeprecationWarning: os.popen3 is deprecated.  Use the subprocess module.
Comment 3 Hugo Mildenberger 2009-11-22 17:44:08 UTC
(In reply to comment #2)
As for the remaining os.popen3 deprecation warning, the patch added to http://bugs.gentoo.org/show_bug.cgi?id=293859 cures this 
annoyance also.
Comment 4 Nico Baggus 2010-06-24 01:07:10 UTC
app-admin/webapp-config-1.50.16-r3  still exhibits the md5 warning.
Comment 5 Robert Trace 2010-07-30 17:24:36 UTC
(In reply to comment #4)
> app-admin/webapp-config-1.50.16-r3  still exhibits the md5 warning.

So, almost a year since the original report and a two line patch hasn't made it in yet...

Gentoo activity on webapp-config (excepting some trivial infrastructure updates) looks to have died about 2 years ago.  Upstream's last check-in was even longer than that.

I think webapp-config is dead.
Comment 6 Nico Baggus 2010-11-23 15:33:55 UTC
That's queer for a tool that is at the core of web based services in a distribution....

But I agree, no followup after a year.. 
So how are we configuring web application in the near future on gentoo....
Comment 7 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-03-22 11:06:12 UTC
*** Bug 358357 has been marked as a duplicate of this bug. ***
Comment 8 Nico Baggus 2012-02-22 10:59:00 UTC
I didn't see this message appear anymore as of lately?
Is it time to close it as nothing done [ still 1.50.16-r1 is the released version ] 

fixed by unkonown other changes (probably in python)?
Comment 9 Robert Trace 2012-02-22 19:58:46 UTC
> Is it time to close it as nothing done [ still 1.50.16-r1 is the released
> version ] 

Just because it's not being vocal about it doesn't make it less of a bug.  In some ways, it makes it more of a bug and even more important to leave this report open.

> fixed by unkonown other changes (probably in python)?

Looks that way.  Python 2.7 started ignoring DeprecationWarning[1].

[1] http://docs.python.org/library/warnings.html#warning-categories
Comment 10 Devan Franchini (RETIRED) gentoo-dev 2013-03-27 21:21:19 UTC
Patch is tested and (clearly) sane. Works out fine.
Comment 12 Anthony Basile gentoo-dev 2013-08-03 14:15:19 UTC
(In reply to Anthony Basile from comment #11)
> committed
> 
> http://git.overlays.gentoo.org/gitweb/?p=proj/webapp-config.git;a=commit;
> h=cb8d8aba36328ed5196adca572466e655932d511

please test webapp-config-1.51 which includes this commit