Bug 28234 – psmisc killall segmentation fault (segv)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Grant McDorman 2003-09-08 20:26:31 UTC]

killall _process_ crashes with a segmentation fault when some process contains a command 
line of 128 bytes or more. 
 
This is due to erroneous coding at line 209: 
  if(!realloc(&command_buf, cmd_size)) 
'realloc' does *not* take a pointer to the pointer to the memory to be reallocated; it takes the 
memory pointer itself and returns a new pointer. The line should read: 
  if(!(command_buf = realloc(command_buf, cmd_size))) 
(if one wants to keep it as one line.) 
 
On my system, the process that caused the problem was a CUPS print job. 
 
The attached patch contains this change.

[Comment 1 Grant McDorman 2003-09-08 20:27:10 UTC]

Created attachment 17305 [details, diff]
Proposed patch for psmisc killall

[Comment 2 Grant McDorman 2003-09-08 20:28:37 UTC]

Oops, forgot to name the file (although it should be obvious from the patch or inspecting the 
source): killall.c. 

[Comment 3 Martin Schlemmer (RETIRED) 2003-09-14 11:26:49 UTC]

I could not recreate it, but it does look fishy.  Fixed in -r4, thanks.