Bug 281990 – games-puzzle/sgt-puzzles-8605 --as-needed fix

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description James Rowe 2009-08-19 06:07:22 UTC]

games-puzzle/sgt-puzzles-8605 fails to build with --as-needed due to
ordering, the attached patches fix this.  It changes the Makefile
generator instead of the actual Makefile, because it is a much cleaner
diff ;)  I'm unsure how easy this is to add to the svn ebuild, as I can't 
install svn on this system to test it.

  Thanks for getting this in the tree too, it is one of my favourite
packages.

Thanks,

James


Reproducible: Always

[Comment 1 James Rowe 2009-08-19 06:08:20 UTC]

Created attachment 201670 [details, diff]
sgt-puzzles-8605-as_needed_fix.patch

[Comment 2 James Rowe 2009-08-19 06:09:09 UTC]

Created attachment 201672 [details, diff]
sgt-puzzles-8605-build_fixes.patch

[Comment 3 James Rowe 2009-08-19 06:18:34 UTC]

Created attachment 201674 [details, diff]
sgt-puzzles-8605-build_fixes_plus.patch

  [Thinking about this some more...]

  Or perhaps this, possibly better, version which wraps the --as-needed
fix, and also the sed for pkg-config and xFLAGS changes that are
currently in the ebuild.  The obvious advantage being that you'll get a
loud build failure if the patch fails to apply when bumping instead of the
close-to-silence in the event that the sed fixes no longer apply.

[Comment 4 Tupone Alfredo 2009-09-11 12:02:41 UTC]

Fixed. Thanks for report and suggestions