Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 281910 - overlays.g.o broken: Git pre-receive hook fail
Summary: overlays.g.o broken: Git pre-receive hook fail
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Infrastructure
Classification: Unclassified
Component: Git (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Infrastructure
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-18 12:36 UTC by Tomáš Chvátal (RETIRED)
Modified: 2009-08-18 17:24 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
typo fix patch (0001-Fix-the-owner-for-hardended-overlay-missing.patch,742 bytes, patch)
2009-08-18 12:37 UTC, Tomáš Chvátal (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomáš Chvátal (RETIRED) gentoo-dev 2009-08-18 12:36:52 UTC
When i was adding hardended-develop overlay i managed to write:
owner Hardended
instead of:
owner = Hardended.

Now when i try to push fix to it or revert the commit i get python traceback:
Traceback (most recent call last):
  File "/usr/bin/gitosis-serve", line 8, in <module>
    load_entry_point('gitosis==0.2', 'console_scripts', 'gitosis-serve')()
  File "/usr/lib64/python2.5/site-packages/gitosis/app.py", line 36, in run
    return app.main()
  File "/usr/lib64/python2.5/site-packages/gitosis/app.py", line 46, in main
    self.read_config(options, cfg)
  File "/usr/lib64/python2.5/site-packages/gitosis/app.py", line 87, in read_config
    cfg.readfp(conffile)
  File "/usr/lib64/python2.5/ConfigParser.py", line 286, in readfp
    self._read(fp, filename)
  File "/usr/lib64/python2.5/ConfigParser.py", line 490, in _read
    raise e
ConfigParser.ParsingError: File contains parsing errors: /var/spool/gitosis/.gitosis.conf
        [line 446]: 'owner Hardened Team <hardened@gentoo.org>\n'
fatal: The remote end hung up unexpectedly


Expected:
It should not allow me to push it, or it should check the state in post-update instead of pre-recieve so we can allways push fixes.

Will attach the patch with fix for the typo.
Comment 1 Tomáš Chvátal (RETIRED) gentoo-dev 2009-08-18 12:37:37 UTC
Created attachment 201605 [details, diff]
typo fix patch

The patch fixing the gitosis.conf
Comment 2 Jory A. Pratt gentoo-dev 2009-08-18 12:50:11 UTC
Keep hardened team in the light :)
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-08-18 17:24:33 UTC
fixed