Bug 28167 – sys-devel/omni ebuild violates setting $A policy

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description SpanKY 2003-09-08 01:23:20 UTC]

you cannot set the A variable in ebuilds, but the following ebuild has:
sys-devel/omni/omni-1.4a.ebuild:A=Omni-${PV}.tar.gz

[Comment 1 Martin Holzer (RETIRED) 2003-09-29 15:14:07 UTC]

possible solution ?

Index: omni-1.4a.ebuild
===================================================================
RCS file: /home/cvsroot/gentoo-x86/sys-devel/omni/omni-1.4a.ebuild,v
retrieving revision 1.2
diff -u -b -B -r1.2 omni-1.4a.ebuild
--- omni-1.4a.ebuild    6 Sep 2003 08:07:33 -0000       1.2
+++ omni-1.4a.ebuild    29 Sep 2003 22:13:41 -0000
@@ -7,8 +7,9 @@
 LICENSE="Omni"
 SLOT="0"
 KEYWORDS="~x86"
-S=${WORKDIR}/Omni-${PV}
-A=Omni-${PV}.tar.gz
+S=${WORKDIR}/${MY_P}
+MY_P=Omni-${PV}
+RESTRICT="fetch"

 IUSE="java doc"

@@ -19,21 +20,18 @@
 RDEPEND="java? ( virtual/jdk )"

 src_unpack() {
-
-       if [ ! -e ${DISTDIR}/${A} ] ; then
+       if [ ! -e ${DISTDIR}/${MY_P}.tar.gz ] ; then
                einfo "Due to license issues you have to download"
                einfo "the appropriate Omni archive:"
                einfo "http://phase.etl.go.jp/Omni/Omni-release.html"
-               einfo "Please get the file "${A}
+               einfo "Please get the file "${MY_P}.tar.gz
                einfo ""
                einfo "The archive should be placed into ${DISTDIR}."

                die "package archive not found"
        fi

-       unpack ${A}
-
-
+       unpack ${MY_P}.tar.gz
 }

 src_compile() {
@@ -43,8 +41,7 @@

        # There is no configure script for the doc
        if [ ! `use doc` ]  ; then
-           mv Makefile.in Makefile.in.orig
-           sed s/doc// Makefile.in.orig > Makefile.in
+           sed s/doc// Makefile.in
        fi

        use java && myconf="${myconf} --with-jvm=yes"

[Comment 2 Olivier Crete (RETIRED) 2003-09-30 04:20:12 UTC]

good solution, my gentoo box is not internet connected yet, feel free to
commit..

shouldnt the sed part be esed instead ?

[Comment 3 SpanKY 2003-09-30 04:41:56 UTC]

what is esed ?

[Comment 4 Olivier Crete (RETIRED) 2003-09-30 05:05:07 UTC]

err dosed or whatever...  I mean running sed like that will just output the
result to stdout...

[Comment 5 Olivier Crete (RETIRED) 2003-10-20 03:29:32 UTC]

fixed the ebuild, thanks..