Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 281323 - net-misc/putty-0.60 does not fail gracefully. QA warnings
Summary: net-misc/putty-0.60 does not fail gracefully. QA warnings
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: High normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-13 14:01 UTC by Christopher Friedt
Modified: 2009-08-18 15:22 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
putty-0.60-ebuild-fail-properly.patch (putty-0.60-ebuild-fail-properly.patch,641 bytes, patch)
2009-08-13 14:02 UTC, Christopher Friedt
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Friedt 2009-08-13 14:01:49 UTC
The net-misc/putty-0.60 ebuild reports a 'false positive' when it builds. It does not fail gracefully or correctly.

I tried to build putty on my netbook, which I have lightened slightly by eliminating most system header files with INSTALL_MASK, and the ebuild finished properly, although there were no binaries generated. 

The ebuild did not fail when the build failed, nor did it fail when it attempted 'dobin' on a non-existent file. 

 * QA Notice: file does not exist:
 * 
 * 	dobin: pterm does not exist
 * 	dobin: putty does not exist
 * 	dobin: puttytel does not exist
 * 	dobin: puttygen does not exist
 * 	dobin: plink does not exist
 * 	dobin: pscp does not exist
 * 	dobin: psftp does not exist


Please see the patch for a fix.

Reproducible: Always

Steps to Reproduce:
1.emerge putty
2.
3.

Actual Results:  
 * QA Notice: file does not exist:
 * 
 * 	dobin: pterm does not exist
 * 	dobin: putty does not exist
 * 	dobin: puttytel does not exist
 * 	dobin: puttygen does not exist
 * 	dobin: plink does not exist
 * 	dobin: pscp does not exist
 * 	dobin: psftp does not exist


Expected Results:  
failure (this would be the correct result)

failed
Comment 1 Christopher Friedt 2009-08-13 14:02:25 UTC
Created attachment 201132 [details, diff]
putty-0.60-ebuild-fail-properly.patch
Comment 2 Víctor Ostorga (RETIRED) gentoo-dev 2009-08-18 15:22:14 UTC
Thanks for the heads up, btw || die should not be called in a subshell because it simply won't work