Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 27995 - Request xxdiff ebuild allow optional KDE support
Summary: Request xxdiff ebuild allow optional KDE support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-05 06:17 UTC by Carl Hudkins
Modified: 2003-10-17 02:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xxdiff-2.9.2.ebuild.patch (xxdiff-2.9.2.ebuild.patch,628 bytes, patch)
2003-09-06 15:48 UTC, Theofilos Intzoglou
Details | Diff
kdesupport.patch (kdesupport.patch,590 bytes, patch)
2003-09-06 15:50 UTC, Theofilos Intzoglou
Details | Diff
Optional KDE support & ebuild cleanup (kxxdiff-2.9.2.patch,959 bytes, patch)
2003-09-06 19:47 UTC, Carl Hudkins
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carl Hudkins 2003-09-05 06:17:03 UTC
With version 2.6, xxdiff now may be compiled against kdelibs, allowing some sort 
of KDE support in the application. As "kde" is a USE flag, I think xxdiff should be 
built with KDE support if that flag is enabled. 

Reproducible: Always
Steps to Reproduce:
1.
2.
3.


Expected Results:  
 

Adding KDE support is done by changing 3 lines in src/xxdiff.pro before building the 
Makefile. I have been attempting to get this to work, but the build currently 
bombs because ld cannot find -lkdeui. If I get this working, I will post my ebuild.
Comment 1 Theofilos Intzoglou 2003-09-06 15:48:34 UTC
Created attachment 17193 [details, diff]
xxdiff-2.9.2.ebuild.patch

Apply this patch to the ebuild
Comment 2 Theofilos Intzoglou 2003-09-06 15:50:04 UTC
Created attachment 17194 [details, diff]
kdesupport.patch

Add this in /usr/portage/dev-util/xxdiff/files/ dir
Comment 3 Theofilos Intzoglou 2003-09-06 15:51:30 UTC
Now these patches allow the program to be compiled with kde support. The binary that is created seems to work just fine. Just don't ask me what kind of extra things it adds :-) I leave that to you ;-)
Comment 4 Carl Hudkins 2003-09-06 18:28:12 UTC
Rats, you beat me to the ebuild submission!  :) 
That's essentially what I did here, except I was trying to make the ebuild change xxdiff.pro using 
"dosed" instead of an external patch file.  (Oh, and I had removed some redundant things from 
the ebuild, like IUSE="" and S=${WORKDIR}/$P.)  However, since I don't seem to understand 
"dosed" (it doesn't actually *do* anything here), it's back to the old-fashioned way! 
Thanks for your work; now everyone else can enjoy the lovely KDE support of xxdiff -- which is 
basically use of kfiledialog and making the widgets follow the user's theme.  I really miss the 
extra up-arrow at the bottom of scrollbars, so of course I had to have it.  :) 
Comment 5 Carl Hudkins 2003-09-06 19:47:00 UTC
Created attachment 17205 [details, diff]
Optional KDE support & ebuild cleanup

Also removes superfluous items from ebuild, such as IUSE="".  Such things are
implied if not defined, so defining them to their default values is pointless.
Comment 6 Caleb Tennis (RETIRED) gentoo-dev 2003-09-15 19:53:25 UTC
put your patch stuff in - -r1.  Let me know if there's any problems.  Thanks! 
Comment 7 Martin Blais 2003-10-16 22:54:32 UTC
whoah... sexy.  i had never even seen it myself with kde widgets.  i had
merely patched up someone else's contribution.   how cool!  now that i run
gentoo myself, all i had to do was emerge! :-)

(the author of xxdiff)