Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 279798 - net-libs/xulrunner installs files with double prefix
Summary: net-libs/xulrunner installs files with double prefix
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All All
: High normal
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-31 12:53 UTC by Thomas Burkard
Modified: 2009-08-01 02:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to correct install paths (xulrunner-1.9.1-r01.1.ebuild.patch,569 bytes, patch)
2009-07-31 12:55 UTC, Thomas Burkard
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Burkard 2009-07-31 12:53:19 UTC
emerging net-libs/xulrunner-1.9.1-r1 in prefix will abort with the message

"Aborting due to QA concerns: double prefix files installed"

the issue is in the ebuild's src_install(). the spurious lines are:
dosym "${MOZLIBDIR}/xulrunner" "${EROOT}/usr/bin/xulrunner-${MAJ_PV}"
dosym "${MOZLIBDIR}/python/xpcom" "${EROOT}/$(python_get_sitedir)/xpcom"

the problem is that prefix' dosym itself adds ${EPREFIX} to the 2nd argument so it ends up as ${EPREFIX}/${EROOT} which is ${EPREFIX}/${ROOT}${ERPEFIX}


Reproducible: Always

Steps to Reproduce:
1. emerge xulrunner with eprefix other than "/"

Actual Results:  
aborted build and message 
"Aborting due to QA concerns: double prefix files installed"


Expected Results:  
successfull install of xulrunner

in the gentoo-x86 the corresponding lines are:
dosym "${MOZLIBDIR}/xulrunner" "${ROOT}/usr/bin/xulrunner-${MAJ_PV}"
dosym "${MOZLIBDIR}/python/xpcom" "${ROOT}/$(python_get_sitedir)/xpcom"

if i understand the developer docs correctly the usage of ${ROOT} is wrong here as it should only be used if ${D} is not used. but ${D} is implicitely added by dosym.

so this is actually a bug in x86 and it could (and imho should) be fixed there.
Comment 1 Thomas Burkard 2009-07-31 12:55:39 UTC
Created attachment 199743 [details, diff]
patch to correct install paths

this patch puts the correct paths to the dosym commands by stripping off the superfluous ${EROOT}
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-07-31 14:59:31 UTC
I don't think $ROOT should be used in src_install()
Comment 3 Fabian Groffen gentoo-dev 2009-07-31 15:26:56 UTC
gx86 should be fixed in this respect, synced to prefix now
Comment 4 Jory A. Pratt gentoo-dev 2009-08-01 02:28:02 UTC
(In reply to comment #3)
> gx86 should be fixed in this respect, synced to prefix now
> 

(In reply to comment #1)
> Created an attachment (id=199743) [edit]
> patch to correct install paths
> 
> this patch puts the correct paths to the dosym commands by stripping off the
> superfluous ${EROOT}
> 

(In reply to comment #2)
> I don't think $ROOT should be used in src_install()
> 

I appreciate all the comments, I exspecially agree that ${ROOT} should not be using in src_install() hense I am appling this patch to mozilla overlay so we can get it pushed to tree for -r2 revision.