Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 279786 - x11-plugins/gkrellmss stupid pkg_preinst tests
Summary: x11-plugins/gkrellmss stupid pkg_preinst tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Jim Ramsay (lack) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-31 11:35 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-08-03 16:15 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (gkrellmss-2.6-r1:20090731-102849.log,3.70 KB, text/plain)
2009-07-31 11:35 UTC, Diego Elio Pettenò (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2009-07-31 11:35:17 UTC
Really, in pkg_preinst, you check whether at least one USE flag is enabled?

Now the test happens _after the build completed_ which is _quite_ stupid. Please do the test in pkg_setup and set a default USE flag through EAPI=1 so that most users won't hit it by default.

[Yes I do sound harsh, but heck this is the first time I see something this absurd… and arch teams marked this one stable?!]
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-07-31 11:35:39 UTC
Created attachment 199732 [details]
Build log
Comment 2 Jim Ramsay (lack) (RETIRED) gentoo-dev 2009-08-03 13:34:18 UTC
(In reply to comment #0)
> [Yes I do sound harsh, but heck this is the first time I see something this
> absurd… and arch teams marked this one stable?!]

Really?  I'm... honoured(?)... to have made such a novel (and/or stupid) mistake ;)

Thanks for catching this, I've changed the check to pkg_setup.

But as for the USE-default, I'm not sure I can know what the appropriate default is.  I hope that users would have one or the other of these global USE flags set globally, depending on their sound system preferences.
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-08-03 13:42:51 UTC
Given esd is being deprecated, the choice seems quite obvious to me…
Comment 4 Jim Ramsay (lack) (RETIRED) gentoo-dev 2009-08-03 14:29:00 UTC
(In reply to comment #3)
> Given esd is being deprecated, the choice seems quite obvious to me…

But forcing on a global USE flag at the package level seems wrong to me, especially when 'alsa' is already set in profiles/targets/desktop/make.defaults
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-08-03 14:43:28 UTC
Given that I'm speaking on behalf of QA: it's not wrong, just do it!
Comment 6 Jim Ramsay (lack) (RETIRED) gentoo-dev 2009-08-03 16:15:09 UTC
(In reply to comment #5)
> Given that I'm speaking on behalf of QA: it's not wrong, just do it!

Ah, didn't realize you were speaking ex cathedra ;)

Done!