Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 279096 - download distfiles to a temporary file and rename upon successful completion
Summary: download distfiles to a temporary file and rename upon successful completion
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Enhancement/Feature Requests (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 377365
  Show dependency tree
 
Reported: 2009-07-25 20:30 UTC by Sven
Modified: 2023-08-30 07:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sven 2009-07-25 20:30:12 UTC
Hi,

developing my own ebuilds, I regularly notice, that "ebuild digest" calculates the digest of broken files.

This is because, sometimes, a downloads gets aborted, I press Strg+C or something else happends so that the downloaded file is cut off at the end.

"ebuilds digest" of course doesn't notice that simply because it cannot since the necessary information is not there yet.

That's why I would like to suggest, that "ebuild digest" downloads the files to a temporary file first, that's renamed to the real filename only if the download was successful.

For example:
- download to xyz.tar.gz.tmp
- rename to cyz.tar.gz only if download was successful





Reproducible: Always

Steps to Reproduce:
1. do a "ebuild digest"
2. abort the download
3. do the ebuild digest again
4. it will compute the checksums using the partial file