278976 – xfce-extra/xfce4-volstatus-icon crashes instead of opening dialog or menu

Bug 278976 - xfce-extra/xfce4-volstatus-icon crashes instead of opening dialog or menu

Summary: xfce-extra/xfce4-volstatus-icon crashes instead of opening dialog or menu

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High critical
Assignee:	XFCE Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2009-07-24 20:18 UTC by Łukasz Stelmach
Modified:	2009-08-01 01:38 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Introduce neccesary new variable. (xfce4-volstatus-icon-0.1.0-dialogsegfault.diff,989 bytes, patch) 2009-07-24 20:19 UTC, Łukasz Stelmach	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Łukasz Stelmach 2009-07-24 20:18:43 UTC

There is a stupid bug in xfce4-volstatus-icon/xfce-volstatus-dialog.c. The same variable (l) is being used twice in two different for loops. The attached patch is from upstream SVN.

Reproducible: Always

Steps to Reproduce:
1. run volstatus-icon
2. righ or left click the icon


Actual Results:  
crash!

Expected Results:  
A dialog or a menu to chose a volume to unmount/eject should appear.

Comment 1 Łukasz Stelmach 2009-07-24 20:19:37 UTC

Created attachment 199025 [details, diff]
Introduce neccesary new variable.

Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester

2009-08-01 01:38:25 UTC

added to -r1, thx