Bug 278930 – app-portage/portpeek-1.8.5 needs to be updated to work with gentoolkit-0.3.0

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Paul Varner (RETIRED) 2009-07-24 14:29:10 UTC]

portpeek relies on gentoolkit and since gentoolkit-0.3.0 is a major rewrite some of the functions in the library have been changed.  The current version of portpeek doesn't work with gentoolkit-0.3.0. One example:

# portpeek -r -a

package.keywords:

package.unmask:
Traceback (most recent call last):
  File "/usr/bin/portpeek", line 702, in <module>
    get_recursive_info(USER_CONFIG_PATH + "/package.unmask")
  File "/usr/bin/portpeek", line 282, in get_recursive_info
    get_info(filename)
  File "/usr/bin/portpeek", line 302, in get_info
    diffs_found = parse_line(line, filename);
  File "/usr/bin/portpeek", line 158, in parse_line
    pkgs = gentoolkit.find_packages(fields[0], True)
AttributeError: 'module' object has no attribute 'find_packages'


Reproducible: Always

Steps to Reproduce:
1. Install portpeek and gentoolkit-0.3.0*
2. run portpeek
3.

Actual Results:  
Traceback on some gentoolkit calls


I will work on a patch for the latest version of portpeek and attach to the bug. (unless someone beats me to it)

[Comment 1 Mike Pagano 2009-07-24 16:47:37 UTC]

Thanks, Paul. You shouldn't have to be bothered with this. I'll take it.

Mike

[Comment 2 Paul Varner (RETIRED) 2009-07-24 16:55:10 UTC]

Created attachment 199001 [details, diff]
gentoolkit compatibility patch

First attempt.  It ugly, since all it does is map the correct things into the gentoolkit namespace if we are using gentoolkit-0.3.0

[Comment 3 Mike Pagano 2009-07-27 15:41:00 UTC]

Thanks, Paul.

Fixed and released in portpeek-1.9.0 with a dependency on >gentoolkit-0.3.0_rcX

Mike