Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 278899 - dev-lang/ruby-1.9.1_p243
Summary: dev-lang/ruby-1.9.1_p243
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-24 05:07 UTC by Daniel Robbins
Modified: 2009-09-09 14:48 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Modified 1.9.1_p243 ebuild (ruby-1.9.1_p243.ebuild,5.57 KB, text/plain)
2009-08-02 03:33 UTC, John W Higgins
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Robbins 2009-07-24 05:07:52 UTC
Here is an ebuild for dev-lang/ruby-1.9.1_p243. Note that I've modified this ebuild to use /usr/bin/ruby1.9 rather than /usr/bin/ruby19. This is to be consistent with Gentoo's python versioning, I figure consistency is a good thing.

I have gone through all the patches that were included in 1.9.1_p129, reviewed them, and removed the ones already applied upstream. The only possible exception is the freebsd7 patch - it's hard for me to tell if it's still needed. If it is, it may need to be reworked a bit for p243.

You will also need the new eselect-ruby ebuild from the second link:

http://github.com/funtoo/portage/commit/a7b7fa1a200847929a8b1e000de784fb7a81081d

http://github.com/funtoo/portage/commit/cdcdaf374095e3e665706fef158ffc552261a51f

Regards,

Daniel

Reproducible: Always
Comment 1 John W Higgins 2009-08-02 03:32:19 UTC
While I am the first person to hate to complain about something Daniel Robbins' worked on - this is a very bad idea with little to no gain. 

Changing the install path messes up any existing gems that are installed either via emerge or gem install. It's also missing the gem patches to add the --sandbox-fix option to gem.

Something as simple as attempting to get rake to re-install after upgrading doesn't seem to want to work.

Reversing the path change and adding the 2 patches makes this run very smoothly.
Comment 2 John W Higgins 2009-08-02 03:33:14 UTC
Created attachment 199877 [details]
Modified 1.9.1_p243 ebuild
Comment 3 Daniel Robbins 2009-08-02 03:56:12 UTC
John, you are right in that existing stuff will reference the old ruby path, and that will break. For Funtoo, I think I can work around that with a modification to install an extra symlink for 1.9. As I don't think anyone was using 1.9 prior to these changes in Funtoo Linux, I think we are OK. Am I correct in my understanding of the problem introduced by changing from "ruby19" to "ruby1.9" in the ebuild, and I can address it by making "ruby19" work again, or are there other things that I'm not quite getting? If so, let me know.

The rationale for the path change is that the "ruby1.9" name seems to be the most common suffix. I saw it used on MacOS X ports systems and Debian (so presumably Ubuntu as well?) You are not obligated in any way to make the switch for Gentoo, I am not trying to force it on you, just sending you my ebuild. If Gentoo wanted to make the change too, I think that adding a "ruby19" symlink to "ruby1.9" would allow this ebuild to work for Gentoo, if you wanted to switch over as well.

Funtoo Linux is an independent project so sometimes I'll decide to change things in Funtoo Linux from how they are in Gentoo if they don't seem right to me. But I am not claiming that my way is the way you should do it, and I'm interested in the technical feedback you have on why my changes may not be optimal, or how they may break existing installs.
Comment 4 Daniel Robbins 2009-08-02 03:59:55 UTC
Oops, I forgot that I changed the install path too, was thinking you were talking about the suffix as I forgot about changing that install path. /me takes look at ebuild.
Comment 5 Daniel Robbins 2009-08-02 04:04:02 UTC
OK - so changing the suffix changes the install path, and that breaks things. I'll add the missing patches to my ebuild. I think I'm going to keep the new install path/suffix for Funtoo.
Comment 6 John W Higgins 2009-08-02 04:12:53 UTC
Hi Daniel,

I know at least one person was using 1.9 in Funtoo and that would be me :)
That's how I hit the bug because I updated my install to your latest and
greatest and then came upon this bug :)

I get that Funtoo is on the edge with a lot of things - this is just an edge
I'm not wanting walking out on for now :)

I understand your reasons behind the change - I'm just thinking that the
install path issue raises a lot of issues - especially with existing packages
that are installed (gem or otherwise).

Thanks for all the hard work - if I can help resolve this in any way let me
know.
Comment 7 Daniel Robbins 2009-08-02 04:18:20 UTC
Aha, that's what I get for trying to rush through a bug report. I assumed you were a Gentoo ruby developer commenting on the bug. In general, if you have issues with Funtoo-specific stuff, it's best to follow up on the funtoo-dev mailing list, rather than post in the Gentoo bugzilla. I put this bug here to provide my ebuild upstream for Gentoo.

I sincerely appreciate the feedback and want to see if we can make the ebuild work better, I just don't want to clutter up Gentoo bugzilla with Funtoo-specific stuff :) Do you agree with the concept of moving to a "ruby1.9" suffix, and are just hitting some big snags with the transition? If you could do me a favor and re-post the problems you are having to funtoo-dev (subscription info on the web site) then we can move the conversation over here and not clutter up Gentoo's bugzilla.
Comment 8 Alex Legler (RETIRED) archtester gentoo-dev Security 2009-08-02 08:18:43 UTC
Eh, yeah.

We're not changing the suffix on Gentoo at this point. We'd have to change all other versions as well (talk about consistency!) and as we saw here that would give us one hell of a breakage.

Thank you for all the ebuilds, I'll happily diff my way through them.
Comment 9 Alex Legler (RETIRED) archtester gentoo-dev Security 2009-09-09 14:48:48 UTC
Done. Thanks.