27888 – Portage notice to replace /etc/make.globals is confusing; patch to fix.

Bug 27888 - Portage notice to replace /etc/make.globals is confusing; patch to fix.

Summary: Portage notice to replace /etc/make.globals is confusing; patch to fix.

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All All

Importance:	High minor (vote)
Assignee:	Portage team

URL:	http://james.is.never.wrong.nu/portag...
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2003-09-03 18:32 UTC by James Harlow (RETIRED)
Modified:	2003-12-24 18:18 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
patch to fix this bug. (no-confusing-message.patch,759 bytes, patch) 2003-09-03 18:34 UTC, James Harlow (RETIRED)	Details \| Diff
patch to fix this bug. (no-confusing-message.patch,759 bytes, text/plain) 2003-09-03 18:34 UTC, James Harlow (RETIRED)	Details
patch to fix this bug. (no-confusing-message.patch,759 bytes, text/plain) 2003-09-03 18:34 UTC, James Harlow (RETIRED)	Details
patch to fix the problem described. (no-confusing-message.patch,759 bytes, text/plain) 2003-09-03 18:36 UTC, James Harlow (RETIRED)	Details
patch to fix the problem described. (no-confusing-message.patch,759 bytes, text/plain) 2003-09-03 18:38 UTC, James Harlow (RETIRED)	Details
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description James Harlow (RETIRED) gentoo-dev

2003-09-03 18:32:28 UTC

When emerging a new version of portage, an important-looking message is printed:

* NOTICE: PLEASE *REPLACE* your make.globals.

This seems to be confusing: many people on #gentoo believe this means "please
replace your make.globals as opposed to not replacing your make.globals", as
opposed to "please replace your make.globals as opposed to merging in the
changes", which I assume is the correct meaning.

Reproducible: Always
Steps to Reproduce:
1. issue `emerge portage`.
2. take note of the frantic beeping and read the error message that is printed.
3. <strike>profit.</strike>

Actual Results:  
Confusion as to what I should do - I don't have anything to replace
/etc/make.globals with.

Expected Results:  
Not printed this warning if there wasn't an updated make.globals.

I've filed this as the category above trivial because I've seen some rather
distressed people wondering what to do, it would be a shame if they did
something to trash their system because of this.

Comment 1 Mr. Bones. (RETIRED) gentoo-dev

2003-09-03 18:33:48 UTC

I agree with the bug reporter that the output about make.globals should be changed.

Comment 2 James Harlow (RETIRED) gentoo-dev

2003-09-03 18:34:05 UTC

Created attachment 17024 [details, diff]
patch to fix this bug.

I apologise for the test, it's pretty ugly but I couldn't think offhand of a
better way to do it.

Comment 3 James Harlow (RETIRED) gentoo-dev

2003-09-03 18:34:24 UTC

Created attachment 17025 [details]
patch to fix this bug.

Comment 4 James Harlow (RETIRED) gentoo-dev

2003-09-03 18:34:46 UTC

Created attachment 17026 [details]
patch to fix this bug.

Comment 5 James Harlow (RETIRED) gentoo-dev

2003-09-03 18:36:12 UTC

Created attachment 17028 [details]
patch to fix the problem described.

Comment 6 James Harlow (RETIRED) gentoo-dev

2003-09-03 18:38:51 UTC

Created attachment 17029 [details]
patch to fix the problem described.

Comment 7 James Harlow (RETIRED) gentoo-dev

2003-09-03 18:44:41 UTC

Argh. I kept getting errors uploading, so I assumed the patch wasn't being uploaded. Can someone delete all but the first? It makes me look like a complete muppet.

Comment 8 Nicholas Jones (RETIRED) gentoo-dev

2003-12-24 18:18:19 UTC

This has been done.