Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 27882 - sys-apps/cloop: insufficient kernel configuration checking
Summary: sys-apps/cloop: insufficient kernel configuration checking
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Stuart Herbert (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-03 13:51 UTC by splite
Modified: 2004-01-15 14:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description splite 2003-09-03 13:51:53 UTC
sys-apps/cloop checks whether ZLIB_*FLATE have been set to "y" in the kernel
config, but simply defining those isn't sufficient to cause the library routines
to be included in the kernel.  The linker will not load them into the kernel
image if nothing calls them.  /usr/src/linux/lib/Config.in lists the symbols
that require ZLIB_*FLATE.  The ebuild could check for those symbols, or just
include a message warning the user to configure at least one of them.

Reproducible: Always
Steps to Reproduce:
1.emerge sys-apps/cloop
2.depmod -a
3.insmod cloop

Actual Results:  
# depmod -a
depmod: *** Unresolved symbols in /lib/modules/2.4.22/misc/cloop.o
# insmod cloop
Using /lib/modules/2.4.22/misc/cloop.o
/lib/modules/2.4.22/misc/cloop.o: unresolved symbol zlib_inflate
/lib/modules/2.4.22/misc/cloop.o: unresolved symbol zlib_inflate_workspacesize
/lib/modules/2.4.22/misc/cloop.o: unresolved symbol zlib_inflateInit_
/lib/modules/2.4.22/misc/cloop.o: unresolved symbol zlib_inflateReset
/lib/modules/2.4.22/misc/cloop.o: unresolved symbol zlib_inflateEnd



This happens with kernels 2.4.21 and 2.4.22.
Comment 1 Stuart Herbert (RETIRED) gentoo-dev 2003-09-04 06:07:21 UTC
Thanks for pointing this out! 
 
I've updated the ebuild to work out what the required symbols are, and to check 
whether any of them are enabled.  If not, the ebuild dies.  I figured a warning would 
just scroll off the screen and be missed by a lot of people. 
 
The fixes should be appearing on your rsync mirror within the hour.  Would you 
mind giving them a go, and letting me know whether they work for you too? 
 
Thanks, 
Stu 
Comment 2 splite 2003-09-12 14:17:25 UTC
They work, nice job.  I did notice that the ebuild still checks for ZLIB_DEFLATE, which isn't necessary for cloop.
Comment 3 nicolasm 2003-11-14 09:23:07 UTC
Not sure this is supposed to be here, but: how does one force ZLIB_DEFLATE to 'Y' instead of 'M' in the kernel config? Cause it always reverts to 'M' for me, and I can't force it to be compiled in the kernel. I tried editing .config by hand, but make oldconfig reverts it back to 'M'.

Any idea? The answer should be put in the ebuild error message, maybe. This got me very confused.
Comment 4 Stuart Herbert (RETIRED) gentoo-dev 2003-11-24 14:46:53 UTC
When you make menuconfig, go to the zlib options, and press 'Y' ?  Or am I missing something here?

Stu
Comment 5 Axxackall 2004-01-15 02:26:20 UTC
I am one who is missing something for sure. ZLIB must be enabled in "Library Routines", right? Then why when I try to enter to that category in menuconfig, it doesn't let me in?
Comment 6 Stuart Herbert (RETIRED) gentoo-dev 2004-01-15 14:31:56 UTC
Read /usr/src/linux/lib/Config.in.  You'll see the rules that govern whether ZLIB is available at all, and whether it's offered as a module or as something you can compile in.

Best regards,
Stu