Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 278728 - dev-util/git-1.6.3.3 tests hang on t7502-commit.sh
Summary: dev-util/git-1.6.3.3 tests hang on t7502-commit.sh
Status: RESOLVED NEEDINFO
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-22 18:31 UTC by Michael Edenfield
Modified: 2009-09-30 07:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Edenfield 2009-07-22 18:31:57 UTC
When running the test suite for git-1.6.3.3, the process hangs during the test group in t7502-commit.sh.  The failing test is #18 in that file, which checks that a SIGTERM during a commit will break the locks.  However, the test never completes.

Reproducible: Always

Steps to Reproduce:
1. FEATURES="test" emerge git

Actual Results:  
Test suite runs up through t7502-commit.sh test #17 ("Editor does not fire in the presence of conflicts"), then emerge process freezes.




Expected Results:  
Test suite should continue to completion and allow git to emerge.

Once the process freezes, the ps output includes the following items:

portage  10661  0.0  0.1   6752  2048 pts/0    S+   Jul21   0:00 /bin/sh t7502-commit.sh
portage  10872  0.0  0.1   6464  2380 pts/0    S+   Jul21   0:00 git commit -a
portage  10873  0.0  0.0      0     0 pts/0    Z+   Jul21   0:00 [FAKE_EDITOR] <defunct>

By sending a SIGKILL to the `git commit` process, the test continues and fails with the following messages:

* FAIL 18: a SIGTERM should break locks

                echo >>negative &&
                ! "$SHELL_PATH" -c '
                  echo kill -TERM $$ >> .git/FAKE_EDITOR
                  GIT_EDITOR=.git/FAKE_EDITOR
                  export GIT_EDITOR
                  exec git commit -a' &&
                test ! -f .git/index.lock

The contents of the FAKE_EDITOR file is:

#! /bin/sh
# kill -TERM command added below.
kill -TERM 10872
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-07-31 08:40:24 UTC
Please retest with 1.6.3.4 and 1.6.4.
Comment 2 Michael Edenfield 2009-07-31 15:41:12 UTC
I see the exact same behavior in 1.6.4
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-09-16 01:34:33 UTC
I still can't reproduce this at all on my machines.
Can you provide more information about your set?

Your info here suggests that the GIT_EDITOR setting is not being respected, and that another edit is maybe being fired up.
Comment 4 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-09-30 07:22:32 UTC
No response from user.