Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 27853 - sys-devel/distcc-2.10-r2 uses wrong GTK USE-Flag
Summary: sys-devel/distcc-2.10-r2 uses wrong GTK USE-Flag
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High major
Assignee: Lisa Seelye (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-03 03:52 UTC by Sven Blumenstein (RETIRED)
Modified: 2003-09-03 12:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Blumenstein (RETIRED) gentoo-dev 2003-09-03 03:52:56 UTC
The distccmon-gnome app uses a GTK2 based GUI but the ebuild checks for 'use
gtk' instead of 'use gtk2' and also got 'gtk' in its RDEPEND.

Here is a patch for 2.10-r2:

--- distcc-2.10-r2.ebuild       2003-08-16 01:06:33.000000000 +0200
+++ distcc-2.10-r2.ebuild.new   2003-09-03 12:43:19.000000000 +0200
@@ -18,7 +18,7 @@
        >=sys-devel/gcc-config-1.3.1
        sys-apps/shadow"
 
-RDEPEND="gtk? ( >=x11-libs/gtk+-2.2.1 )
+RDEPEND="gtk2? ( >=x11-libs/gtk+-2.2.1 )
        selinux? ( sec-policy/selinux-distcc )"
 
 
@@ -26,7 +26,7 @@
        local myconf="--with-included-popt "
        #Here we use the built in parse-options package.  It saves a dependancy
 
-       use gtk && myconf="--enable-gnome"
+       use gtk2 && myconf="--enable-gnome"
 
        econf ${myconf} || die "econf ${myconf} failed"
        emake || die "emake failed"
Comment 1 Lisa Seelye (RETIRED) gentoo-dev 2003-09-03 08:18:42 UTC
This is not a bug.

gtk2 is ONLY to discriminate when you want gtk version 2 over gtk version 1 in an application that supports _BOTH_ gtk v1 and gtk v2.
Comment 2 Sven Blumenstein (RETIRED) gentoo-dev 2003-09-03 08:30:01 UTC
And why do applications like Gkrellm handle it in the following way?

DEPEND=">=sys-apps/sed-4
    gtk? (  >=x11-libs/gtk+-2.0.5 )
    gtk2? ( >=x11-libs/gtk+-2.0.5 )"

(from gkrellm-2.1.16.ebuild)

My understanding is that 

use gtk = install gtk1
use gtk2 = install gtk2

And as distccmon-gnome uses gtk2, it should take this use flag.
Comment 3 Ian Leitch (RETIRED) gentoo-dev 2003-09-03 12:35:57 UTC
http://www.gentoo.org/dyn/use-index.xml says:

gtk:  Adds support for x11-libs/gtk+ (The GIMP Toolkit)
gtk2: Use gtk+-2.0.0 over gtk+-1.2 in cases where a program supports both. Beware that gtk+-2 support can be bad.