Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 277810 - dev-libs/botan does not fail when tests fails
Summary: dev-libs/botan does not fail when tests fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Crypto team [DISABLED]
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-14 14:20 UTC by Xake
Modified: 2009-08-17 20:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Xake 2009-07-14 14:20:12 UTC
This seems to be a problem with botan's makesystem since the ebuild has the "| die" stuff.

When I experienced bug 274709 I tried to remerge botan since it came right after I rebuild monotone due to linking issues against botan.
When I saw the buildlog for butan it said that botan failed nearly every test due to that specific issue. However emerge still went on and merged the package.

With other words: even when botan fails tests (which it never should unless something is wrong) the merge still completes, merging a broken lib.
Comment 1 Xake 2009-07-14 17:54:11 UTC
This seems to be fixed in upstream mtn, but apparently it will be for 1.8.5 and above.
The change in question seems to be:

============================================================
--- checks/check.cpp    59dacb23c1c0e968a4bcd2897230ddb2f0f02740
+++ checks/check.cpp    a60a362d7a91abd6b74154d4006ec3520a1795ce
@@ -122,7 +122,7 @@ int main(int argc, char* argv[])

       if(opts.is_set("validate") || opts.is_set("test"))
          {
-         run_test_suite(rng);
+         return run_test_suite(rng);
          }
       if(opts.is_set("bench-algo") ||
          opts.is_set("benchmark") ||

I letting this bug stay open so maintainer can decide on whether applying this change to earlier versions (which cannot break anything but src_test() and that during build) or close waiting for an upstream release with the change.
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-08-17 20:22:50 UTC
Fixed in dev-libs/botan-1.8.5.