Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 277092 - Missing || die calls in ebuild using build-docbook-catalog
Summary: Missing || die calls in ebuild using build-docbook-catalog
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-08 19:21 UTC by Jonas Bernoulli
Modified: 2009-07-09 15:55 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Bernoulli 2009-07-08 19:21:21 UTC
I have had a lot's of problems building xmlto and packages that depend on it while creating a stage3. Normally these problems do not manifest on a live system because required but unspecified dependencies have already been merged once xmlto and it's dependencies, and build-docbook-catalog are installed.

1. xmlto does depend on sys-apps/which
2. build-docbook-catalog does depend on || ( sys-apps/util-linux app-misc/getopt )

Another problem is that build-docbook-catalog will fail if /etc/xml does not exist. Some of the packages (all?) that call build-docbook-catalog during pkg_postinst do not previously create /etc/xml.

To make things worse non of these ebuilds die if build-docbook-catalog fails.

Could you please:
1. Add above dependencies
2. Make sure that all packages that call build-docbook-catalog first merge /etc/xml
3. Add ||die after all calls to build-docbook-catalog in all ebuilds. (If that had been done previously these bugs would have shown up earlier I think).

Possibly other dependencies of xmlto have missing dependencies too, wouldn't surprise me much (no bad feelings - just saying it might be good to check).


Reproducible: Always
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2009-07-08 19:56:53 UTC
Bug wranglers: I've fixed build-docbook-catalog deps and xmlto deps (getopt and which) so this is now partly solved (Thanks Jonas)
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2009-07-08 20:19:57 UTC
I've dropped "keepdir /etc/xml" to build-docbook-catalog's ebuild which should solve issue 2.

So we are only missing || die's from end of build-docbook-catalog's in multiple different ebuild(s) around tree, right? Changed summary to reflect the situation.
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2009-07-08 21:28:15 UTC
I'm not sure if it's safe to add these dies.. since build-docbook-catalog does

Found DocBook XSL stylesheets (xsl) in /usr/share/sgml/docbook/xsl-stylesheets
Found DocBook XSL stylesheets (xsl-ns) in /usr/share/sgml/docbook/xsl-ns-stylesheets
DocBook XSL stylesheets (xsl-saxon) not found
DocBook XSL stylesheets (xsl-xalan) not found

see the "not found"'s and they vary on different systems, what code (0, 1?) does the command return in these cases? i guess you could check by "echo $?" after the command (should return the code)

just thinking out loud
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2009-07-09 15:55:29 UTC
Since 1. and 2. are solved I don't think 3. is so important anymore (see prev. comment)

Please report if you have more issues wrt docbook / xml deps