Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 276024 - [PATCH] www-client/mozilla-firefox-3.5 ebuild needs NOSHORTLANGS update
Summary: [PATCH] www-client/mozilla-firefox-3.5 ebuild needs NOSHORTLANGS update
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-01 04:33 UTC by Hector Martin
Modified: 2009-07-02 06:57 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Add es-CL and es-MX to NOSHORTLANGS (mozilla-firefox-spanish-noshortlangs.patch,533 bytes, patch)
2009-07-01 04:34 UTC, Hector Martin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hector Martin 2009-07-01 04:33:14 UTC
Several es-* languages have been added but are missing from NOSHORTLANGS. When building with LINGUAS="es" it tries to use all of them and ends up with the first one, which is es-CL. The default for "es" should be es-ES per prior mozilla ebuilds.
Comment 1 Hector Martin 2009-07-01 04:34:36 UTC
Created attachment 196222 [details, diff]
Add es-CL and es-MX to NOSHORTLANGS
Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev 2009-07-01 06:37:06 UTC
On a similar note, en-US is missing from LANGS. As a result, if you have LINGUAS="en ru" or something similar in make.conf, the ebuild will completely ignore English, and firefox will be built with only Russian localization.

So en-US needs to be re-added to LANGS like in the mozilla-firefox-3.0.* ebuilds.
Comment 3 Hector Martin 2009-07-01 12:59:19 UTC
I believe en-us is handled internally. I have LINGUAS="es" and I can make Firefox work in English just by disabling the spanish language pack/extension.
Comment 4 Alexandre Rostovtsev (RETIRED) gentoo-dev 2009-07-01 13:51:18 UTC
(In reply to comment #3)
> I believe en-us is handled internally. I have LINGUAS="es" and I can make
> Firefox work in English just by disabling the spanish language pack/extension.

No, you can't. If you do that, the main Firefox UI will work in English, but all of your extensions will be in Spanish.

DownThemAll, Flashblock, Greasemonkey, Stylish etc. will all use the browser's primary language (Spanish in your case) even if you disable the Spanish language pack in the add-ons menu.
Comment 5 Hector Martin 2009-07-01 14:14:26 UTC
Yes, I got that too, but it's an easy fix. Go to about:config and change general.useragent.locale to en-US.
Comment 6 Alexandre Rostovtsev (RETIRED) gentoo-dev 2009-07-01 15:04:00 UTC
(In reply to comment #5)
> Yes, I got that too, but it's an easy fix. Go to about:config and change
> general.useragent.locale to en-US.

Interesting. Thanks for telling me about this.

Still, the ebuild needs to allow building a multilingual English and Spanish version of Firefox (like it did for firefox-3.0, 2.0, and all other versions) instead of requiring users to go through strange undocumented workarounds.

All other Linux software switches locale by reading your LANG environment variable. If an ebuild makes Firefox's behavior different (instead of honoring your environment variables, it now requires users to edit about:config), that is a bug.
Comment 7 Hector Martin 2009-07-01 18:08:56 UTC
I agree that it is undesirable behavior. You should open a separate bug for it.
Comment 8 Jory A. Pratt gentoo-dev 2009-07-02 00:07:36 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > Yes, I got that too, but it's an easy fix. Go to about:config and change
> > general.useragent.locale to en-US.
> 
> Interesting. Thanks for telling me about this.
> 
> Still, the ebuild needs to allow building a multilingual English and Spanish
> version of Firefox (like it did for firefox-3.0, 2.0, and all other versions)
> instead of requiring users to go through strange undocumented workarounds.
> 
> All other Linux software switches locale by reading your LANG environment
> variable. If an ebuild makes Firefox's behavior different (instead of honoring
> your environment variables, it now requires users to edit about:config), that
> is a bug.
> 

Actually it is not a bug, it has always worked this way. This was one of the main reasons I really did not want to support languages via the ebuild, Make the default english and let everyone else add there native language via the addons menus. This is what mozilla herd really needs to discuss and go back to IMO.
Comment 9 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-07-02 06:57:49 UTC
(In reply to comment #6)
> All other Linux software switches locale by reading your LANG environment
> variable. 

I agree that firefox should try to honour one's LANG env. var, please open another bug for tracking this.

OTOH, NOSHORTLANGS has been updated with -r1, thanks for reporting :)