Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 274081 - x11-misc/xscreensaver-5.08 needs X-XFCE in Categories for Manager
Summary: x11-misc/xscreensaver-5.08 needs X-XFCE in Categories for Manager
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Desktop Misc. Team
URL: http://forums.gentoo.org/viewtopic-p-...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-14 00:24 UTC by nm (RETIRED)
Modified: 2009-08-25 11:57 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description nm (RETIRED) gentoo-dev 2009-06-14 00:24:16 UTC
Xscreensaver no longer has an entry in my Xfce menu, because its .desktop file is invalid. It also doesn't appear in the Xfce Settings Manager for the same reason.

Here's what I mean:

$ desktop-file-validate xscreensaver-properties.desktop 
error: file contains key "_Name" in group "Desktop Entry", but key names must contain only the characters A-Za-z0-9- (they may have a "[LOCALE]" postfix)
error: file contains key "_Comment" in group "Desktop Entry", but key names must contain only the characters A-Za-z0-9- (they may have a "[LOCALE]" postfix)
error: required key "Name" in group "Desktop Entry" is not present


. . . and no, I can't get make quick fix for the Gentoo ebuild because I don't have access to the tree; my perms are in other trees. I hope upstream can get out a quick fix; if not, perhaps it's something we need to patch temporarily in Gentoo.

CCing upstream as requested by metadata.xml.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2009-06-19 11:55:51 UTC
This was because of invalid patch that removed usage of intltool IIRC

(re)emerging latest should solve the problem, it's so minor problem it hardly deserves a revbump but i'll get the latest revision stabled now
Comment 2 nm (RETIRED) gentoo-dev 2009-06-20 01:56:59 UTC
Only partly fixed. While xscreensaver does now show up in the Settings menu, it doesn't appear in the Xfce4 settings manager.

Samuli, you were in the xfce team . . . did you ever hear about apps not getting picked up by x-s-m? I'm wondering if there's another entry needed in the .desktop file.

I could just be misremembering; maybe it never appeared in the x-s-m dialog in the first place. I thought it did, but maybe not? All the apps in the dialog have this in their .desktop entries:

Categories=X-XFCE

. . . so perhaps xscreensaver doesn't need to have that entry, as it's not exclusively an xfce app.

I guess there's no real further investigation *needed* by you or upstream, so you can close the bug as you see fit. I'm still a bit puzzled, but at least xscreensaver now shows up in the toplevel Settings menu. Thanks!
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2009-06-22 07:51:22 UTC
(In reply to comment #2)
> Categories=X-XFCE

It's not like it's NotShowIn -function for the rest, this might end up in the .desktop file.
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-08-01 01:44:27 UTC
Confused, anything need to be done here still?
Comment 5 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2009-08-23 02:57:59 UTC
(In reply to comment #4)
> Confused, anything need to be done here still?
> 

Guess not. removing xfce@g.o. Add back if you want me to do something.
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2009-08-25 11:57:04 UTC
+  25 Aug 2009; Samuli Suominen <ssuominen@gentoo.org>
+  xscreensaver-5.08-r2.ebuild, +files/xscreensaver-5.08-X-XFCE.patch:
+  Add X-XFCE; to Categories of .desktop file for better integration with
+  Xfce4.