Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 274074 - media-sound/gnomoradio: fails with forced --as-needed
Summary: media-sound/gnomoradio: fails with forced --as-needed
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High QA (vote)
Assignee: Gentoo Sound Team
URL: http://www.gentoo.org/proj/en/qa/asne...
Whiteboard:
Keywords:
Depends on:
Blocks: as-needed
  Show dependency tree
 
Reported: 2009-06-13 23:53 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-07-18 10:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Build log (gnomoradio-0.15.1:20090613-184502.log,41.40 KB, text/plain)
2009-06-13 23:53 UTC, Diego Elio Pettenò (RETIRED) 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2009-06-13 23:53:02 UTC 
I'm reporting this bug because the package in summary fails to build when forcing --as-needed on through spec files (check out http://blog.flameeyes.eu/2008/11/14/problems-and-mitigation-strategies-for-as-needed for details).

Please note that this bug _might_ apply to -Wl,--as-needed in LDFLAGS as well; in both cases it should be fixed. Also, if this is due to the package in question not respecting user-defined LDFLAGS, you should get to fix that too.

Check the attached build log.

Thanks,
Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-06-13 23:53:23 UTC 
Created attachment 194596 [details]
Build log
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2009-07-18 10:39:51 UTC 
Missing -lm, but I didn't see any "LDFLAGS not respected" while building; with just asneeded in LDFLAGS at make.conf. But, it seemed simple enough to fix:

  18 Jul 2009; Samuli Suominen <ssuominen@gentoo.org>
+  gnomoradio-0.15.1.ebuild, +files/gnomoradio-0.15.1-lm.patch:
+  Insert -lm to LIBADD for forced asneeded wrt #274074.

--- gnomoradio-0.15.1.orig/roboradio/mp3/Makefile.am	2004-06-15 08:45:35.000000000 +0300
+++ gnomoradio-0.15.1/roboradio/mp3/Makefile.am	2009-07-18 13:35:08.000000000 +0300
@@ -44,7 +44,7 @@
 	mpg123.h				\
 	tabinit.c				\
 	$(optimized_source)
-libroboradio_mp3_la_LIBADD = -lpthread \
+libroboradio_mp3_la_LIBADD = -lm -lpthread \

No system to test solution, so closing as TEST-REQ.