Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 273321 - sys-block/open-iscsi: package unconditionally links statically
Summary: sys-block/open-iscsi: package unconditionally links statically
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mike Doty (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-09 11:56 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2009-11-12 09:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2009-06-09 11:56:11 UTC
I'm reporting this bug because your package is currently using static linking on at least part of the files it installs:

sys-block/open-iscsi (/usr/sbin/iscsistart)


Now, while there are packages for which the static linking is mandatory, if it's just that it's desired, you should make it optional via USE flag default for +static with EAPI=1.

Static linking _may_ be a security issue, thus shouldn't be forced on. If your package is actually a prebuilt or proprietary package, you should install in /opt instead.
Comment 1 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-06-09 18:10:20 UTC
This is what is used to generate the binary:
cc  -march=nocona -O2 -pipe -g -Wall -Wstrict-prototypes -I../include -DLinux -DNETLINK_ISCSI=8 -D_GNU_SOURCE -static netlink.o util.o io.o auth.o login.o log.o md5.o sha1.o iface.o idbm.o sysdeps.o sysfs.o iscsi_sysfs.o initiator.o scsi.o actor.o mgmt_ipc.o isns.o transport.o ../utils/fwparam_ibft/fw_entry.o ../utils/fwparam_ibft/fwparam_ibft.o ../utils/fwparam_ibft/fwparam_ppc.o ../utils/fwparam_ibft/prom_lex.o ../utils/fwparam_ibft/prom_parse.tab.o iscsistart.o statics.o -o iscsistart

The file is for usage inside initramfs during boot, when you need to have root-on-iSCSI. It's got no usage outside of that.
Comment 2 SpanKY gentoo-dev 2009-06-12 08:13:50 UTC
there are a lot of people who dont use/want initramfs/initrd's.  forcing static binaries on them for that isnt right.

the original request is sane
Comment 3 Stefan Behte (RETIRED) gentoo-dev Security 2009-08-08 12:51:56 UTC
root-on-iSCSI is not included in genkernel yet and will build iscsistart by itself, see #209817. IMHO, we can move away from compiling statically without any problems.
Comment 4 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2009-11-12 09:30:26 UTC
Fixed in 2.0.871-r1