I use vim (never gvim) in both console and X (as I'm sure a great many people also do) and forcing --without-x on the vim compile removes all of the features normally enabled when running vim in an xterm, such as automatically copying a vim visual block to the X clipboard.
It appears the ebuild buils two different versions of vim, if the GUI is set it builds the gvim version, and builds the console version.. The console version has the --without-x in it. Am I missing something?
Yes you are :-) The "console" version isn't just for console--it can be run in an xterm and still intergrate with X11. This is the prefered way of running it for a lot of people who like to run everything in terminals or just find the gui version cumbersome. On a side note, there really is no reason to build the two binaries separately as the ebuild does currently--there isn't an overlap of features unless --without-x is enabled and it should not be.
committed