Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 272079 - net-misc/openvpn: including support for eurephia
Summary: net-misc/openvpn: including support for eurephia
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Cédric Krier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-01 12:22 UTC by David Sommerseth
Modified: 2009-10-22 11:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild file for OpenVPN 2.1_rc16 (openvpn-2.1_rc16.ebuild,4.35 KB, text/plain)
2009-06-01 12:23 UTC, David Sommerseth
Details
Corrected ebuild file for OpenVPN 2.1_rc16 (openvpn-2.1_rc16.ebuild,4.34 KB, text/plain)
2009-06-01 12:29 UTC, David Sommerseth
Details
ebuild file for OpenVPN 2.1_rc17 (openvpn-2.1_rc17.ebuild,4.95 KB, text/plain)
2009-06-01 14:37 UTC, David Sommerseth
Details
patch openvpn-2.1_rc15-ebuild to 2.1_rc18 (openvpn-2.1_rc15_to_rc18.ebuild.patch,2.00 KB, patch)
2009-06-08 08:26 UTC, Marcel Pennewiß
Details | Diff
openvpn/openvpn-2.1_rc18.ebuild (openvpn-2.1_rc18.ebuild,4.77 KB, text/plain)
2009-06-08 08:27 UTC, Marcel Pennewiß
Details
openvpn/openvpn-2.1_rc18.ebuild (openvpn-2.1_rc18.ebuild,5.08 KB, text/plain)
2009-06-24 07:46 UTC, Marcel Pennewiß
Details
openvpn-2.1_rc18.ebuild (openvpn-2.1_rc18.ebuild,5.02 KB, text/plain)
2009-06-24 07:48 UTC, Marcel Pennewiß
Details
patch openvpn-2.1_rc15-ebuild to 2.1_rc18 (openvpn-2.1_rc15_to_rc18.ebuild.patch,2.06 KB, patch)
2009-06-24 07:50 UTC, Marcel Pennewiß
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Sommerseth 2009-06-01 12:22:52 UTC
Updated the ebuild file to include support for the latest OpenVPN 2.1_rc16, including the needed patch to make OpenVPN work with eurephia (http://www.eurephia.net).  This patch is enabled by adding "eurephia" to the USE flags.

Reproducible: Always

Steps to Reproduce:
This new ebuild works as expected.
Comment 1 David Sommerseth 2009-06-01 12:23:32 UTC
Created attachment 193129 [details]
ebuild file for OpenVPN 2.1_rc16

Attached ebuild file
Comment 2 David Sommerseth 2009-06-01 12:28:28 UTC
Comment on attachment 193129 [details]
ebuild file for OpenVPN 2.1_rc16

Discovered an error in DESCRIPTION.  New ebuild will follow
Comment 3 David Sommerseth 2009-06-01 12:29:58 UTC
Created attachment 193133 [details]
Corrected ebuild file for OpenVPN 2.1_rc16

Attached new and corrected ebuild file with correct DESCRIPTION
Comment 4 David Sommerseth 2009-06-01 14:37:45 UTC
Created attachment 193149 [details]
ebuild file for OpenVPN 2.1_rc17

Admittedly, I should of course have checked if it was an even fresher version than 2.1_rc17 ... anyway, the latest and greatest.  FYI: the 2.1_rc17 was released May 30, 2009.
Comment 5 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-06-06 17:05:34 UTC
Thanks for providing the updated ebuilds. Just some annotations:

Don't hardcode /usr/portage/distfiles into ebuilds. That's what ${DISTDIR} is for.
Furthermore the whole check for the patch in src_unpack is useless. Either the USE flag is set, then portage fetches the patch anyway or stops with an error message when it cannot fetch the file or the USE flag is unset then portage won't fetch the patch of course.

Try to use something like this:


EUREPHIA_PATCH="openvpn-${PV}_eurephia.patch"
SRC_URI="http://openvpn.net/release/openvpn-${PV}.tar.gz 
         eurephia? ( http://master.dl.sourceforge.net/sourceforge/eurephia/${EUREPHIA_PATCH} )"


and later in src_unpack():


use eurephia && epatch "${DISTDIR}/${EUREPHIA_PATCH}"


Also consider to provide changes you did to ebuilds as unified diffs (diff -u) as this would be much more handy for our devs.
Comment 6 Marcel Pennewiß 2009-06-08 08:26:10 UTC
Created attachment 193857 [details, diff]
patch openvpn-2.1_rc15-ebuild to 2.1_rc18

newest version with eurephia-support based on ebuild for 2.1_rc15
Comment 7 Marcel Pennewiß 2009-06-08 08:27:17 UTC
Created attachment 193858 [details]
openvpn/openvpn-2.1_rc18.ebuild

complete ebuild with eurephia-support based on 2.1_rc15-ebuild
Comment 8 Marcel Pennewiß 2009-06-08 08:30:14 UTC
(In reply to comment #0)
> Updated the ebuild file to include support for the latest OpenVPN 2.1_rc16,
> including the needed patch to make OpenVPN work with eurephia
> (http://www.eurephia.net).  This patch is enabled by adding "eurephia" to the
> USE flags.

Hi, thanks for the new ebuilds. I think it would be better to use the latest ebuild for an updated version.
Comment 9 Marcel Pennewiß 2009-06-24 07:46:26 UTC
Created attachment 195631 [details]
openvpn/openvpn-2.1_rc18.ebuild

Add ebuild-bugfixes from #263136 and #272994.
Comment 10 Marcel Pennewiß 2009-06-24 07:48:39 UTC
Created attachment 195633 [details]
openvpn-2.1_rc18.ebuild

Add ebuild-bugfixes from #263136 and #272994.
Now without the ipv6-patch ;)
Comment 11 Marcel Pennewiß 2009-06-24 07:50:20 UTC
Created attachment 195635 [details, diff]
patch openvpn-2.1_rc15-ebuild to 2.1_rc18

Add ebuild-bugfixes from #263136 and #272994.
Comment 12 David Sommerseth 2009-07-16 12:40:14 UTC
openvpn-2.1_rc19 is released.  Copying openvpn-2.1_rc18.ebuild to openvpn-2.1_rc19.ebuild enables this new release without any issues.  Tested on x86, with USE="eurephia pam ssl".

What is the release process to get this ebuild into the main repositories?
Comment 13 Cédric Krier gentoo-dev 2009-08-01 15:05:50 UTC
Version bump in CVS
For the eurephia patch, try to ask upstream to include it.
Comment 14 David Sommerseth 2009-08-01 16:34:23 UTC
(In reply to comment #13)
> Version bump in CVS
> For the eurephia patch, try to ask upstream to include it.
> 

I have done that:
http://sourceforge.net/tracker/?func=detail&aid=1986805&group_id=48978&atid=454721
http://sourceforge.net/mailarchive/forum.php?thread_name=486B1657.4000409%40topphemmelig.net&forum_name=openvpn-devel

Please, have a look at the dates ... it's over a year ago.

And James Yonan (OpenVPN main developer) said in an e-mail directly that he consider that when he gets confidence in people using it.  Anyway, it's plenty of patches available, and the implementation of such patches takes many years to get upstream in OpenVPN.  That's just to look at the release schedule.  OpenVPN 2.0 has been the stable release now since 2006-10-01.  While most people on the mailing list and on IRC consider 2.1_rc15+ to be a stable release.  After all, even Red Hat Enterprise Linux ship 2.1_rc15 as a stable version.  And I wonder how interesting it is for James Yonan to implement this patch, as it seems to touch the grounds of OpenVPN AS (his commercial product).

Do I have to create an official fork of OpenVPN to get this in into Gentoo?
Comment 15 Marcel Pennewiß 2009-08-02 16:20:53 UTC
(In reply to comment #14)
> And James Yonan (OpenVPN main developer) said in an e-mail directly that he
> consider that when he gets confidence in people using it.  Anyway, it's plenty
> of patches available, and the implementation of such patches takes many years
> to get upstream in OpenVPN.  That's just to look at the release schedule. 
> OpenVPN 2.0 has been the stable release now since 2006-10-01.  While most
> people on the mailing list and on IRC consider 2.1_rc15+ to be a stable
> release.  After all, even Red Hat Enterprise Linux ship 2.1_rc15 as a stable
> version.  And I wonder how interesting it is for James Yonan to implement this
> patch, as it seems to touch the grounds of OpenVPN AS (his commercial product).
> 
> Do I have to create an official fork of OpenVPN to get this in into Gentoo?

IMHO it's the same problem like the ipv6-patches. 
Comment 16 Cédric Krier gentoo-dev 2009-10-10 23:48:37 UTC
Add to openvpn-2.1_rc20
Comment 17 David Sommerseth 2009-10-11 00:26:32 UTC
As the summary of this bug now is "net-misc/openvpn: including support for eurephia" ... I'm reopening this one, as this update do not include the eurephia support.

But the rc18 ebuild file works fine with rc20 + eurephia on a couple of machines I've tested this on.
Comment 18 Cédric Krier gentoo-dev 2009-10-11 08:31:59 UTC
(In reply to comment #17)
> As the summary of this bug now is "net-misc/openvpn: including support for
> eurephia" ... I'm reopening this one, as this update do not include the
> eurephia support.
> 
> But the rc18 ebuild file works fine with rc20 + eurephia on a couple of
> machines I've tested this on.
> 

I don't understand as 2.1_rc20 has the patch
Comment 19 David Sommerseth 2009-10-22 07:03:58 UTC
(In reply to comment #18)
> (In reply to comment #17)
> > As the summary of this bug now is "net-misc/openvpn: including support for
> > eurephia" ... I'm reopening this one, as this update do not include the
> > eurephia support.
> > 
> > But the rc18 ebuild file works fine with rc20 + eurephia on a couple of
> > machines I've tested this on.
> > 
> 
> I don't understand as 2.1_rc20 has the patch

I am sorry ... but I so much wish this was true.  It is not included in the official OpenVPN versions.  It is hopefully somewhere in a patch queue, but my hope for that right now is low.  But I am maintaining this patch and releasing new versions of it for all new OpenVPN versions, continuously.

Please add this patch to the Gentoo ebuild file.

Comment 20 Marcel Pennewiß 2009-10-22 07:12:27 UTC
> Please add this patch to the Gentoo ebuild file.

See changelog from openvpn-ebuild:

  10 Oct 2009; Cédric Krier <cedk@gentoo.org> openvpn-2.1_rc20.ebuild,
  metadata.xml:
  Add eurephia patch for bug #272079

Cedric included the patch together with the ipv6-patches!
Comment 21 Cédric Krier gentoo-dev 2009-10-22 07:13:05 UTC
(In reply to comment #19)
> (In reply to comment #18)
> > (In reply to comment #17)
> > > As the summary of this bug now is "net-misc/openvpn: including support for
> > > eurephia" ... I'm reopening this one, as this update do not include the
> > > eurephia support.
> > > 
> > > But the rc18 ebuild file works fine with rc20 + eurephia on a couple of
> > > machines I've tested this on.
> > > 
> > 
> > I don't understand as 2.1_rc20 has the patch
> 
> I am sorry ... but I so much wish this was true.  It is not included in the
> official OpenVPN versions.  It is hopefully somewhere in a patch queue, but my
> hope for that right now is low.  But I am maintaining this patch and releasing
> new versions of it for all new OpenVPN versions, continuously.
> 
> Please add this patch to the Gentoo ebuild file.
> 

It is in the ebuild !
Comment 22 David Sommerseth 2009-10-22 11:16:27 UTC
Oh dear ... oh dear ... how blind is it possible to be ... 

I AM VERY SORRY!!!  Yes, I realised now you meant the ebuild ... And it builds well too :)

/me is very much ashamed

Thank you very much for your help ... and patience :)