Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 27196 - kernel development-sources-2.6.0_beta4 make modules_install error?
Summary: kernel development-sources-2.6.0_beta4 make modules_install error?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: x86-kernel@gentoo.org (DEPRECATED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-23 15:53 UTC by Whit Blauvelt
Modified: 2003-08-24 15:52 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Whit Blauvelt 2003-08-23 15:53:36 UTC
# make modules_install
  INSTALL net/ipv4/netfilter/ipt_recent.ko
if [ -r System.map ]; then /sbin/depmod -ae -F System.map  2.6.0-test4; fi

- that if line looks like something to be run, not displayed.

That's at line 600 in the Makefile:

.PHONY: _modinst_post  
_modinst_post: _modinst_
        if [ -r System.map ]; then $(DEPMOD) -ae -F System.map $(depmod_opts)
$(KERNELRELEASE); fi
Comment 1 Tim Yamin (RETIRED) gentoo-dev 2003-08-23 16:58:02 UTC
I don't exactly see what the problem is here. If this is a compile bug and you can't compile the kernel, send it to the kernel developers/LKML and if this is just a bug also send it there too. I assume I can close this bug?

'depmod' is supposed to be run to make a deps file for all the modules so you don't have to do it by yourself...
Comment 2 Whit Blauvelt 2003-08-23 19:00:37 UTC
The problem is that instead of running depmod it's displaying the line with the conditional. There's some sort of syntax error in the Makefile. If you want to leave it to the kernel developers to fix this that's fine by me. I've noticed that some Gentoo packages patch what's broken in the official versions - thought this might be something easy for Gentoo to approach in that way prior to the kernel distribution being fixed; or even might be specifically broken in Gentoo, since I haven't tried the kernel.org version of the sources.
Comment 3 Tim Yamin (RETIRED) gentoo-dev 2003-08-23 19:49:53 UTC
I'll send this along. Gentoo kernels apply new non-vanilla features with patches [LVM, I2C for 2.4, etc...] or fix compile errors. As this compiles, it isn't really a Gentoo bug...

The vanilla dev-kernel should work like the dev-sources as the ebuild for _beta4 does no extra patching...

Thanks for the bug anyway!
Comment 4 SpanKY gentoo-dev 2003-08-24 14:05:16 UTC
uhh, this isnt a bug ... 
thats how a makefile works ... it echos the command and then runs it ... 
 
in this case, depmod didnt have any output thus you saw none ... 
Comment 5 Whit Blauvelt 2003-08-24 15:45:59 UTC
Wouldn't the command to echo have been:  
  
"/sbin/depmod -ae -F System.map  2.6.0-test4"  
  
Instead it echoed:  
  
"if [ -r System.map ]; then /sbin/depmod -ae -F System.map  2.6.0-test4; fi"  
  
In years of running make I can't recall ever seeing a Makefile echo a  
conditional statement, just the commands it has run on account of the (unechoed)  
conditionals in the Makefile having been met. Is this a matter of style rather than 
functionality? 
Comment 6 SpanKY gentoo-dev 2003-08-24 15:52:49 UTC
i see makefiles echo conditional statements all the time 
 
and no, it would have shown whatever was given to the shell ... in this case, the if 
statement was given to the shell rather than the makefile evaluating it 
 
it's a matter of whatever the linux kernel developers want :)