These patches modularize guide.xsl and guide-print.xsl, making them IMHO easier to understand and to maintain. They also make writing handbook.xsl a lot more efficient (see recent postings to gentoo-dev). *They do not change the stylesheets' functionality, i.e. the HTML they generate.* Changes to guide.xsl: * Originally <xsl:template match="/guide"> generated the HTML head, the logobar, the sidebar, etc. as well as the actual content of the page. This moves the part where the actual content of the page is generated to <xsl:template name="makecontent"> and makes the "/guide" template call "makecontent". Thus, stylesheets that want to change only the page's "frame" (like guide-print.xsl) need only override the "/guide" template and do not need to reproduce the content-generating part. Stylesheets that want to change only the page's content (like handbook.xsl) need only override "makecontent" and leaving the HTML table magic necessary for the "frame" to guide.xsl. * Instead of keeping the part which generates the author listing in the content-part commented, I wrapped it in <xsl:if> allowing the calling "/guide" template to choose whether it wants the authors listed there or not. Changes to guide-print.xsl: * The content-generating part that was almost identical to the one in guide.xsl, is replaced by a call to "makecontent". I put these changes in two patch files, because the changes to guide-print.xsl are not required by those two guide.xsl. The second patch _does_ depend on the first, though. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Created attachment 16510 [details, diff] patch to guide.xsl
Created attachment 16511 [details, diff] the patch to guide-print.xsl
To be precise, the content generated by guide-print.xsl is now headed and trailed by an additional <br/>. If that bothers you, I can shift the <br/>s in question out of "makecontent" and back into "/guide".
I believe sven has made these changes. closing bug.
