Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 271050 - Add pulseaudio support to app-emulation/wine
Summary: Add pulseaudio support to app-emulation/wine
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Wine Maintainers
URL: http://bugs.winehq.org/show_bug.cgi?i...
Whiteboard:
Keywords:
: 305675 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-05-24 12:22 UTC by Sergey Ilinykh
Modified: 2010-03-05 18:21 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
wine-1.1.33.ebuild with art's pulseaudio patches included (wine-1.1.33.ebuild,4.49 KB, text/plain)
2009-12-07 04:17 UTC, Matt Carr
Details
wine-1.1.30.ebuild with art's pulseaudio patches included (wine-1.1.30.ebuild,4.10 KB, text/plain)
2009-12-07 08:14 UTC, Matt Carr
Details
updated patch for configure.ac wine 1.1.30 (winepulse-fixedconfigureac.patch.2,3.08 KB, patch)
2010-01-12 13:16 UTC, Miles Robinson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Ilinykh 2009-05-24 12:22:22 UTC
I've found pulseaudio patches on wine bug tracker
http://bugs.winehq.org/show_bug.cgi?id=10495
and people says patches work good.
so, add please these patches into wine package.
at least optionally

Reproducible: Always

Steps to Reproduce:
Comment 1 Rafał Mużyło 2009-05-24 17:03:21 UTC
Well, depending on your setup,
pulseaudio may work out-of-the-box with wine.
Comment 2 Sergey Ilinykh 2009-05-24 18:38:42 UTC
(In reply to comment #1)
> Well, depending on your setup,
> pulseaudio may work out-of-the-box with wine.
> 

that's the reason why not make it native? (not through alsa)
Comment 3 Myk Taylor 2009-10-12 04:14:07 UTC
I've been applying Art Taylor's pulseaudio patches for quite some time now with great success.  Alsa and OSS don't work for me in many applications in wine (crashes, choppy audio, etc.).  Only the native pulseaudio driver works well.  I certainly vote for a "pulseaudio" USE flag that applies these patches.

Remember, one of the patches modifies the configure script, so the ebuild would have to call autoreconf after applying the patches.
Comment 4 Justus Ranvier 2009-10-18 13:20:38 UTC
These patches will not build on amd64 unless 32-bit pulseaudio libraries are installed. (Bug #186820)
Comment 5 SpanKY gentoo-dev 2009-10-19 01:25:45 UTC
there's a whole lot of noise/flak on that report i dont want to touch

you can download the patches and put them into:
/etc/portage/patches/app-emulation/wine/

and then they should get applied automatically when you emerge wine
Comment 6 Myk Taylor 2009-10-19 21:51:55 UTC
(In reply to comment #5)
> there's a whole lot of noise/flak on that report i dont want to touch
yeah.. it seems like a sore spot with the upstream devs

> you can download the patches and put them into:
> /etc/portage/patches/app-emulation/wine/
this won't quite work since the patches change the configure script.  Perhaps a compromise would be to add a autoreconf call at the end of src_prepare() so that cases like this are handled?  Testing with this, it still doesn't completely work since Art's patches need to be applied with -p1 and epatch_user effectively applies them with -p0, so the new files get created in the wrong places, but adding autoreconf is a step in the right direction.
Comment 7 Myk Taylor 2009-10-19 22:36:26 UTC
I found a possible solution:
1) add "autoreconf" to the end of src_prepare() in wine-1.1.31.ebuild
2) combine all of art's patches into one via:
  cat winepulse-winecfg-0.6.patch winepulse-0.32-configure.ac.patch winepulse-0.32.patch >/etc/portage/patches/app-emulation/wine/winepulse.patch

I'll see if I can get Art to put this info on his website, but we would still need to add autoreconf to the ebuild.  Since this bug has already been closed, I'll open a new bug.
Comment 8 SpanKY gentoo-dev 2009-10-19 22:40:04 UTC
i'm not inclined to add a call to autotools when the normal code does not need it.  what you highlight though isnt specific to wine.  all packages that apply user patches to autotool source files are going to have this problem.  i dont have a solution though to the problem ...
Comment 9 Myk Taylor 2009-10-21 04:12:18 UTC
(In reply to comment #8)
> i'm not inclined to add a call to autotools when the normal code does not need
> it.
It is true that this code adds a new feature instead of just patching an old one, but I would still call that "normal".  What is the down side of adding a call to autoreconf, though?  Apart from adding a ~5 second delay to the compilation process, there is no ill effect.  In fact, what is the down side to making a call to autoreconf part of epatch_user?
Comment 10 SpanKY gentoo-dev 2009-10-21 06:40:32 UTC
packages now have to depend on autotools, and epatch_user is implicit in all eutils.eclass inherit.  not acceptable.

also, i'm pretty sure 5 seconds is awfully under estimated
Comment 11 Matt Carr 2009-12-07 04:17:38 UTC
Created attachment 212295 [details]
wine-1.1.33.ebuild with art's pulseaudio patches included

I wasn't able to find an ebuild anywhere that applies Art's patches http://art.ified.ca/?page_id=40 so I wrote my own for wine-1.1.33 that seems to be working fine tested on ~x86 at least.  The ebuild also has a pulseaudio useflag included so you need to add pulseaudio to your /etc/portage/package.use for wine if you want to compile in pulseaudio support.  This ebuild should work for any future patches Art releases as well, just change the filenames of the patches in the ebuild when they come out.  Refer to http://en.gentoo-wiki.com/wiki/Writing_Ebuilds for creating your local overlay and such if need be.
Comment 12 Matt Carr 2009-12-07 08:14:48 UTC
Created attachment 212306 [details]
wine-1.1.30.ebuild with art's pulseaudio patches included

After a bit more testing I found that under 1.1.33 the sound would cut out after a few minutes of gameplay and was also having maybe unrelated issues with another app with 1.1.33 so I went back to 1.1.30 which is what I used before and rewrote that ebuild instead.  The ebuild varies slightly and I had to use the respective patches for 1.1.30 from Art, (winepulse-0.30 patches), you can see them in the ebuild.  Anyways this one seems to work flawlessly so far after a couple hours of testing.
Comment 13 Miles Robinson 2010-01-12 13:16:09 UTC
Created attachment 216223 [details, diff]
updated patch for configure.ac wine 1.1.30

thought i would go ahead and post an updated patch file so that other people could avoid the problems that i myself experienced when trying to use the previously posted ebuild with the latest patches from arts page. hope it works as well for everyone else as it did for me, no hiccups yet at all with wine and pulseaudio output!
Comment 14 SpanKY gentoo-dev 2010-02-18 09:19:56 UTC
*** Bug 305675 has been marked as a duplicate of this bug. ***
Comment 15 Sergey Ilinykh 2010-02-18 09:51:09 UTC
just a link to winepulse project from bug report above, since not everyone like to see duplicates
http://art.ified.ca/?page_id=40

btw current status of this report "RESOLVED UPSTREAM" actually means "WILL BE RESOLVED UPSTREAM ONE DAY" (read article by link above for details)
Comment 16 Pacho Ramos gentoo-dev 2010-02-18 14:39:30 UTC
Yeah, I would reconsider this situation since upstream doesn't want to include it and this is currently needed to get proper sound support with wine+pulseaudio. 

What technical changes are preventing its inclusion from Gentoo wine maintainers point of view? Maybe winepulse upstream would be willing to help :-)

Thanks a lot
Comment 17 SpanKY gentoo-dev 2010-02-18 14:48:51 UTC
man power.  if upstream is going to significantly drag their heels, i can start including it in the ebuilds ... but as soon as the patches rot, i'll just drop until someone else updates them.  i have yet to get pulseaudio to not act like a huge pile of sh*t, so i'm not about to waste time debugging it.
Comment 18 Pacho Ramos gentoo-dev 2010-02-18 15:27:13 UTC
I also don't use pulseaudio yet under Gentoo :-( (but as I could see some time ago in mandriva bugzilla, seemed that pulse patches for wine work ok)

Maybe I could try to contact Stefan Reimer as seems that he's currently maintaining wine ebuilds with pulse plugin in his overlay:
http://www.startux.de/index.php/articles/65-wine-ebuild-integrating-pulseaudio
Comment 19 SpanKY gentoo-dev 2010-03-05 18:09:41 UTC
wine-1.1.39 has untested support for USE=pulseaudio
Comment 20 Pacho Ramos gentoo-dev 2010-03-05 18:21:14 UTC
Great, thanks a lot, I know some people will welcome it :-)