Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 270809 - conky patch to make it work with <x11-wm/awesome-3.3.1 awesome-client
Summary: conky patch to make it work with <x11-wm/awesome-3.3.1 awesome-client
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Daniel Pielmeier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-22 10:01 UTC by Alex Alexander (RETIRED)
Modified: 2009-07-30 21:11 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
conky patch that makes it work with awesome-client (conky-awesome.patch,390 bytes, patch)
2009-05-22 10:02 UTC, Alex Alexander (RETIRED)
Details | Diff
patch for in-tree conky ebuild (conky-1.7.0_rc1.ebuild.awesome.patch,752 bytes, patch)
2009-05-22 10:04 UTC, Alex Alexander (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Alexander (RETIRED) gentoo-dev 2009-05-22 10:01:15 UTC
conky needs a tiny patch to be able to talk to x11-wm/awesome via awesome-client.

this is really useful since awesome doesn't behave well when it gathers stats internally, so by using conky we create a safety layer that allows the WM to work smoothly under heavy load. ( and conky has some neat features built-in anyway =] )

I've added a new USE flag, awesome, to conky's ebuild to toggle the patch on and off since non-awesome users won't like the extra \n added by the patch.

the new ebuild and patch are available in my overlay, wirelay:
http://github.com/wired/wirelay/tree/master/app-admin/conky

I'll attach the patch and a diff for the in-tree ebuild below.
Comment 1 Alex Alexander (RETIRED) gentoo-dev 2009-05-22 10:02:01 UTC
Created attachment 192100 [details, diff]
conky patch that makes it work with awesome-client
Comment 2 Alex Alexander (RETIRED) gentoo-dev 2009-05-22 10:04:42 UTC
Created attachment 192102 [details, diff]
patch for in-tree conky ebuild

adds awesome USE flag
patches conky if use awesome
Comment 3 Daniel Pielmeier gentoo-dev 2009-07-20 19:11:22 UTC
This has already been added upstream but the patch inclusion failed. It is now in again [1].

The way it was implemented does not need a use flag as it adds an additional config option to conkyrc which seems a better approach. So this should be fixed in conky-1.7.2. Feel free to add a patch if you need it desperately :-)

[1] http://git.omp.am/?p=conky.git;a=commitdiff;h=f169e0e0719688cc1b80f474b9ccd7eae6006838
Comment 4 Alex Alexander (RETIRED) gentoo-dev 2009-07-20 19:30:00 UTC
Nice. However it seems that awesome 3.3.1 (hardmasked) which I'm using now doesn't require any patch (tested and works fine with conky-1.7.0_rc1 and 1.7.1.1 w/o patch).

So this patch will still be useful, but only for older awesome versions like latest ~arch :)

Thanks for the update.
Comment 5 Daniel Pielmeier gentoo-dev 2009-07-30 21:11:57 UTC
Fixed in conky-1.7.2_rc2.