Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 269405 - <media-plugins/audacious-plugins-2* have an unneeded dep on musicbrainz
Summary: <media-plugins/audacious-plugins-2* have an unneeded dep on musicbrainz
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-11 13:47 UTC by Rafał Mużyło
Modified: 2009-05-11 16:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rafał Mużyło 2009-05-11 13:47:51 UTC
This is a followup of bug 214588.
I'm leaving it in bug-wranglers, instead of assigning directly 
to the maintainer, as a moderator is needed.
It seems that to prove my point, I need to contact audacious author directly
and paste an email from him.

As I already mentioned there, according to
- configure.ac
- author's forum post
- mercurial commit log
audacious-plugins has not depended on musicbrainz for years.
The var in the Makefile seems to be a leftover from the time
it did, that was not removed when the configure.ac was fixed.

As the authors are now busy with writing 2.0,
I doubt they would be willing to fix anything that not broken
- a var, that's not assigned by configure, will be eval'd
to ''. So, that MUSICBRAINZ_LIBS is still in the Makefile
does *NOT* hurt, it's just another empty string.


Even, if it needed a dep on musicbrainz (which it DOES NOT),
it still should be a slotted dep, as musicbrainz is.
Comment 1 Peter Alfredsen (RETIRED) gentoo-dev 2009-05-11 16:48:10 UTC
 +  11 May 2009; <chainsaw@gentoo.org> audacious-plugins-1.5.1-r1.ebuild,
 +  audacious-plugins-1.5.1-r2.ebuild, audacious-plugins-1.5.1-r3.ebuild,
 +  audacious-plugins-2.0_alpha1.ebuild, audacious-plugins-2.0_alpha3.ebuild:
 +  Drop musicbrainz dependency once and for all. As per upstream bug #63 by
 +  Rafał Mużyło. The Makefile variable suggesting the dependency has been
 +  removed in upstream commit 3166:1ec4aa80d7f9.

Fixed :-)