Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 268941 - x11-misc/xscreensaver-5.08: ripples does not respect -water option
Summary: x11-misc/xscreensaver-5.08: ripples does not respect -water option
Status: RESOLVED CANTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Samuli Suominen (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-07 14:55 UTC by Christian Becke
Modified: 2009-06-21 16:39 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed patch for both ripples hack and man page (xscreensaver_ripples.diff,983 bytes, patch)
2009-05-07 14:58 UTC, Christian Becke
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Becke 2009-05-07 14:55:38 UTC
The "ripples" hack from xscreensaver-5.08 always uses a screen image, regardless whether the option -water is present, omitted, or -no-water is given. Without -water, ripples should use a black background.
Also, ripples does not recognise the options -no-stir and -no-oily mentioned in the man page.
Comment 1 Christian Becke 2009-05-07 14:58:42 UTC
Created attachment 190626 [details, diff]
Proposed patch for both ripples hack and man page

* Make ripples respect the -water option, not using a desktop image by default
* Remove -no-{water,stir,oily} options from the man page
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2009-06-19 12:22:09 UTC
This patch doesn't really work.. before applying it I can see ripples on my grabbed desktop image, after applying it it's all just black blackground with
ripples

(started from xscreensaver-demo's configuration gui)

reopen if you got something else, thanks
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2009-06-19 12:28:02 UTC
I mean it didn't work even when grab desktop image was switched on
Comment 4 Christian Becke 2009-06-21 16:39:24 UTC
Works for me. You have to explicitly add the -water option to the command line:
* Start xscreensaver-demo
* Choose "Ripples (desktop)" in the list
* Click "Settings..."
* Click "Advanced >>"
* Add "-water" to "Command Line:"

For some reason the "-water" option is not kept. I'll look into it, when I find some time.