Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 268376 - sys-apps/hal-0.5.12_rc1-r2 has bad logic for USE="consolekit -policykit"
Summary: sys-apps/hal-0.5.12_rc1-r2 has bad logic for USE="consolekit -policykit"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-03 02:30 UTC by Jonathan Callen (RETIRED)
Modified: 2009-05-09 22:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Callen (RETIRED) gentoo-dev 2009-05-03 02:30:59 UTC
When USE="consolekit -policykit", consolekit support is erroneously disabled, due to bad logic on the econf command line.  The current ebuild passes "--enable-console-kit --disable-console-kit" when consolekit is enabled, and policykit is disabled, which causes consolekit to be disabled, as ./configure takes the last option passed.  The proper way (IMO) to fix this would be to change the line reading "$(use_enable policykit console-kit)" to "$(use policykit && echo --enable-console-kit)", which would cause the correct logic to be used.
Comment 1 Arun Raghavan (RETIRED) gentoo-dev 2009-05-03 17:45:00 UTC
Think it would be better to require +consolekit if +policykit is used. I believe this crazy syntax would work:

        policykit? (
                sys-apps/hal[consolekit]
                ...
        )

Once this is done, the use_enables for console-kit can be interchanged, and things should work just fine (assuming configure always takes the latest enable/disable value passed on the command-line).
Comment 2 Nirbheek Chauhan (RETIRED) gentoo-dev 2009-05-03 17:53:26 UTC
(In reply to comment #1)
> Think it would be better to require +consolekit if +policykit is used. I
> believe this crazy syntax would work:
> 
>         policykit? (
>                 sys-apps/hal[consolekit]
>                 ...
>         )

I believe you're looking for bug 251179
Comment 3 Daniel Gryniewicz (RETIRED) gentoo-dev 2009-05-09 22:13:20 UTC
Good call on the accidental disabling.  I've fixed that in -r3.  The self-reference doesn't work, I tried it.  Maybe after that's approved, we'll make it cleaner.