Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 267965 - x11-wm/ratpoison should utilise more use flags
Summary: x11-wm/ratpoison should utilise more use flags
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Desktop WM Team (OBSOLETE)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-30 09:38 UTC by Nick White
Modified: 2009-05-01 12:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch that moves the ebuild to EAPI=2 and adds IUSE=history (ratpoison-1.4.3-r1.ebuild.patch,1.30 KB, patch)
2009-04-30 11:59 UTC, Jeroen Roovers (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nick White 2009-04-30 09:38:00 UTC
The newest ratpoison (1.4.4; the ebuild needs bumping), should use the following USE flags:

xft
readline

At the moment they're just found automagically. The debian builds do this already, see http://git.savannah.gnu.org/cgit/ratpoison.git/tree/debian/rules for details.

Reproducible: Always

Steps to Reproduce:
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2009-04-30 11:59:00 UTC
Created attachment 189959 [details, diff]
Patch that moves the ebuild to EAPI=2 and adds IUSE=history

I cannot find anything in the ratpoison sources related to x11-libs/libXft, so I ignored that - it could well be that Debian uses that integrally and then ignores the configure warnings for packages that simply don't support xft...

Anyway, this patch introduces IUSE=history, which has the build system use or not use readline's libhistory. If that satisfies your needs, I will commit it shortly.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2009-04-30 12:53:43 UTC
This patch (IUSE=+history) entered into the fresh 1.4.4 ebuild (version bump).
Comment 3 Nick White 2009-04-30 13:12:19 UTC
That patch looks good, and thanks for bumping, but it looks to me in the new (1.4.4) release that there are libXft options in the configure script, which affect the code. This is new in this release, I believe.

It would be worth adding this flag then, too, to control whether --without-xft is passed to ./configure, as this is the kind of option the super-minimalists who are likely to be attracted to ratpoison may like.

Thanks
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2009-05-01 11:27:43 UTC
Well spotted!

In revision 1.4.4-r1, IUSE=xft has been added (as well as debug support).
Comment 5 Nick White 2009-05-01 12:45:11 UTC
That's great, and working well for me.

Thanks alot!