Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 267871 - sys-apps/hal: please add policykit and consolekit USE flag
Summary: sys-apps/hal: please add policykit and consolekit USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Freedesktop bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-29 13:12 UTC by Robert Piasek (RETIRED)
Modified: 2009-04-30 19:22 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to add ck/pk support to hal (hal-pk-ck.patch,2.95 KB, patch)
2009-04-30 16:18 UTC, Daniel Gryniewicz (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Piasek (RETIRED) gentoo-dev 2009-04-29 13:12:34 UTC
Since policykit is no longer masked, please add policykit use flag and replace
--disable-policy-kit \
with use_enable




Reproducible: Always
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-04-30 12:30:41 UTC
should probably also enable consolekit at the same time. I wonder how this will affect current system operation though.
Comment 2 Daniel Gryniewicz (RETIRED) gentoo-dev 2009-04-30 16:18:39 UTC
Created attachment 189978 [details, diff]
patch to add ck/pk support to hal

Okay, there are issues with hal and ck/pk support.  The big issue is that hal's pk support depends on it's ck support; that is, for --enable-policy-kit to work, you *also* need --enable-console-kit.  I came up with 4 options:
1. Separate use flags, and if policykit is given without consolekit, it's disabled
2. Like 1, except die
3. Separate USE flags, except that the policykit flag enables ck support regardless of the status of the consolekit flag
4. Only a policykit flag; there would be no way to get consolekit without policykit

I nuked 1 as a possibility, because it makes USE depends for policykit impossible.  2 is bad, because it dies.  That leaves 3 and 4, and people seem to want the ability to have ck without pk, so I've implemented 3 in the patch above.
Comment 3 Daniel Gryniewicz (RETIRED) gentoo-dev 2009-04-30 19:05:35 UTC
(note, I added [policykit] to the consolekit deps, as appropriate)
Comment 4 Daniel Gryniewicz (RETIRED) gentoo-dev 2009-04-30 19:22:04 UTC
Fixed in 0.5.12_rc1-r1.