New ebuild for wmDiscoTux, an XMMS dockable visualization of a headbanging Tux. Intended for: "media-plugins/xmms-wmdiscotux" Reproducible: Always Steps to Reproduce:
Created attachment 16202 [details] Ebuild file.
Created attachment 16203 [details, diff] Patch file Patch for the Makefile to make it all work.
wmDiscoTux supposedly compiles on ppc, but I don't have a ppc machine to test it on. Please test it. This is my first ebuild, so any feedback is appreciated.
*** Bug 25482 has been marked as a duplicate of this bug. ***
* Applying xmms-wmdiscotux-1.3-makefile.patch... [ ok ] >>> Source unpacked. gcc -march=athlon-xp -O2 -pipe -fomit-frame-pointer -Wall -I/usr/include -I/usr/X11R6/include -I/usr/local/include `gtk-config --cflags` `glib-config --cflags` -fPIC -c -o wmdiscotux.o wmdiscotux.c gcc -march=athlon-xp -O2 -pipe -fomit-frame-pointer -Wall -I/usr/include -I/usr/X11R6/include -I/usr/local/include `gtk-config --cflags` `glib-config --cflags` -fPIC -c -o wmgeneral.o wmgeneral.c wmdiscotux.c:362:32: missing terminating " character wmdiscotux.c: In function `discotux_about': wmdiscotux.c:363: error: syntax error before "wmDiscoTux" wmdiscotux.c:363: error: stray '\' in program wmdiscotux.c:363: error: stray '\' in program wmdiscotux.c:366: error: syntax error at '@' token wmdiscotux.c:366: error: stray '\' in program wmdiscotux.c:368: error: stray '\' in program wmdiscotux.c:369:6: warning: multi-line comment wmdiscotux.c:371:1: missing terminating " character wmdiscotux.c: In function `discotux_init': wmdiscotux.c:478: warning: implicit declaration of function `memset' make: *** [wmdiscotux.o] Error 1
Keith, I'm not able to get it to compile successfully -- care to debug this?
What's your 'emerge info'? Oddly enough, I'm getting the same thing now. It worked for me when I submitted this. Some update may have b0rked it.
Created attachment 17782 [details] ebuild, Manifest, digest, and two patch files. Modified ebuild and a new patch to fix the issue. The author had some very strange escaping going on in wmdiscotux.c in a string for the about box. It seemed to be confusing the newest version of gcc. I will contact the author about this.
as jje pointed out in email, it's a multiline string literal in the source file which causes this (gcc-3.3 does not like multiline string literals)
By "email" I assume you mean some mailing list that I am not subscribed to; unless he emailed you directly about this, in which case your wording could use a little work. ;-) What do you/jje propose? Is my patch acceptable/usable?
How about you attach the patch as plain text and i'll take a look. ;) I've not looked at the code but expressed expectation in a mail to seemant that it would be a multi-line string problem.
Keith, please don't attach tarballs to the bug report. I'd rather view them in the web browser before downloading. Also, Manifests and digests are completely unnecessary submissions, because they get autogenerated (any developer who accepts a submitted one doesn't deserve to be a developer, to be honest).
Created attachment 17812 [details] ebuild
Created attachment 17813 [details, diff] makefile patch
Created attachment 17814 [details, diff] string literal patch Thanks, fellas. Your input is valuable feedback for me.
Keith, my apologies -- my previous comment sounded WAY harsher than it was intended. I'd meant it as a request, and only for future bugs. Anyway, I hope I did not offend you. Apologies again. Thanks for the gcc3.3 patch -- I renamed it to ${P}-gcc-3.3.patch just to be a little more explicit (I think all gcc-3.3 patches in the portage tree are about the multiline string literal issue). Ebuild is in portage -- thanks for it, and looking forward to more ebuilds from you.
One note: I changed your ebuild a bit, so it's immune to version bumps (ie, they should be as simple as just renaming the ebuild when the time comes -- have a look :)
Posting in a closed bug :-O No, it's cool. It really is good stuff to know. ;)
