Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 266433 - www-apache/mod_dnssd-0.6 LDFLAGS support
Summary: www-apache/mod_dnssd-0.6 LDFLAGS support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Apache Team - Bugzilla Reports
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-16 21:11 UTC by Gilles Dartiguelongue (RETIRED)
Modified: 2009-05-04 20:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mod_dnssd-0.6.ebuild.patch (mod_dnssd-0.6.ebuild.patch,770 bytes, patch)
2009-04-16 21:12 UTC, Gilles Dartiguelongue (RETIRED)
Details | Diff
mod_dnssd-0.6-ldflags.patch (mod_dnssd-0.6-ldflags.patch,577 bytes, patch)
2009-04-16 21:12 UTC, Gilles Dartiguelongue (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-04-16 21:11:31 UTC
I saw a few weeks ago that gnome-user-share 2.26 wasn't announcing its shares anymore and that it switched at the same time to using mod_dnssd. I also noticed that portage spewed a warning about it not respecting LDFLAGS and today while I was doing a few other stuff I found out the cause.

Currently the ebuild uses the default src_compile from the inherited eclass which doesn't work since it doesn't know that it should like against avahi. It also doesn't seem to know about ldflags but I'll leave you the opportunity to open a bug or fix it directly yourselves.

Anyway, even with that, src/Makefile.in was still wrong so I fixed it too and will be attaching patches in a moment. Now I can finally enjoyed mDNS announced http shares again.

CCing gnome so we can keep track of this while merging gnome 2.26 to the tree.
Comment 1 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-04-16 21:12:29 UTC
Created attachment 188613 [details, diff]
mod_dnssd-0.6.ebuild.patch
Comment 2 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-04-16 21:12:45 UTC
Created attachment 188614 [details, diff]
mod_dnssd-0.6-ldflags.patch
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-05-03 10:49:17 UTC
I took the liberty to commit these changes. Fill free to stab me if something's wrong.
Comment 4 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-05-04 18:44:38 UTC
The patch is wrong. It prepends '-Wl,' only to first flag(s) in LDFLAGS, so if somebody uses e.g. LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu", --as-needed and --hash-style=gnu will be ignored.
Comment 5 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-05-04 19:34:50 UTC
(In reply to comment #4)
> The patch is wrong. It prepends '-Wl,' only to first flag(s) in LDFLAGS, so if
> somebody uses e.g. LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu",
> --as-needed and --hash-style=gnu will be ignored.
> 

fixing that would be much more expensive, and you can pass LDFLAGS in one -Wl anyway. It's still better this way than completely broken. I'm available for more testing though.
Comment 6 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-05-04 20:20:04 UTC
You can use e.g.:
APXS_LDFLAGS = `for ldflag in $(LDFLAGS); do echo -Wl,$$ldflag; done`
...
$(APXS) -c $(CFLAGS) $(APXS_LDFLAGS) @srcdir@/mod_dnssd.c $(LIBS)
Comment 7 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2009-05-04 20:33:59 UTC
I fixed the patch.