Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 26593 - Default examples in make.conf from livecd are not valid
Summary: Default examples in make.conf from livecd are not valid
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Configuration (show other bugs)
Hardware: x86 Linux
: High normal
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-14 00:19 UTC by jason wohlgemuth
Modified: 2005-02-27 23:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jason wohlgemuth 2003-08-14 00:19:37 UTC
Many of the examples do not show the required quotes. If a user just uncomments 
a line, make.conf will not parse. The error that is given does not really help 
as to what the problem is:

!!! Invalid token (not "=")
!!! Parse error in /etc/make.conf. 
!!! Incorrect multiline literals can cause this. Do not use them. 


Example:

# PORTDIR_OVERLAY is a directory where local ebuilds may be stored without
#     concern that they will be deleted by rsync updates. Default is not
#     defined.
#PORTDIR_OVERLAY=/usr/local/portage

Uncommenting the above line will produce an error when trying to emerge, unless 
you change it to

PORTDIR_OVERLAY="/usr/local/portage"

There are multiple examples in the default make.conf file (as seen on the 
Pentium 3 1.4 CD) that are like that.
Comment 1 Daniel Robbins (RETIRED) gentoo-dev 2003-09-09 15:23:56 UTC
I've fixed everything in gentoo-src/stager/files, so all the stager make.confs should be quoted our double-quoted. Nick, would be nice to upgrade the Portage conf parser to be more bash-like.
Comment 2 Jens Schittenhelm 2004-01-05 06:16:44 UTC
The make.conf created by catalyst (on the 2.6 Live CDs) miss many of the options. Either upgrade the Gentoo Handbook to inform the user what options are needed or putting a note in make.conf telling the user the correct path to an make.conf.example would be helpful.
Comment 3 Benjamin Judas (RETIRED) gentoo-dev 2004-01-05 07:08:25 UTC
I can copy that - the make.conf created by catalyst is quite trivial and includes only minimal options.
Comment 4 Brian Harring (RETIRED) gentoo-dev 2004-08-17 00:55:40 UTC
Guessing this isn't an issue anymore?
Comment 5 Brian Harring (RETIRED) gentoo-dev 2005-02-27 23:14:51 UTC
No complaints of 'still horked' ~== FIXED marking (besides that, it was a livecd issue, not portage)