Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 26578 - americas-army-170 ebuild installs applink in wrong directory
Summary: americas-army-170 ebuild installs applink in wrong directory
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-13 16:55 UTC by Bob Thomas
Modified: 2004-02-23 19:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Thomas 2003-08-13 16:55:51 UTC
americas-army ebuild installs link into "Game" directory, creating a new
directory, instead of into existing "Games" directory. Likely a typo.

Reproducible: Always
Steps to Reproduce:
1. install americas-army
2. link is in wrong directory
3.




this is a one-byte fix. c'mon guys :-p
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2003-08-13 18:58:32 UTC
Try merging it again?  Seems to do the right thing for me.
/usr/games/bin/armyops points to /opt/americas-army/armyops is that not
where it should be pointing?
Comment 2 SpanKY gentoo-dev 2003-08-13 19:58:23 UTC
freedesktop.org spec refers to 'Game' and not 'Games' as the directory name ... 
 
however, this isnt going to be 'fixed' because the part that is affecting you isnt 
ebuild specific ... plus, we are redoing the way the menus are generated 
completely 
 
look for auto menu generation of portage packages in the near future :) 
Comment 3 Nathan Adams 2004-02-17 20:23:41 UTC
This is still broken as of version 2.0.0a. The 'offending' line in the ebuild is:

    make_desktop_entry armyops "AA: Operations" ArmyOps.xpm

If the freedesktop spec is the origin of the typo (it SHOULD be Games and not Game), then somebody needs to mention it to them. Has anyone done this?
Comment 4 SpanKY gentoo-dev 2004-02-17 20:37:12 UTC
http://freedesktop.org/Standards/menu-spec/0.8/apa.html
http://freedesktop.org/Standards/menu-spec/0.4/apa.html

if it's a typo, it's survived all the versions

they also typed it wrong a few times since i see:
Game	A game	 	 
ActionGame	An actiongame	Game	 
AdventureGame	Adventure style game	Game	 
ArcadeGame	Arcade style game	Game	 
BoardGame	A board game	Game	 
BlocksGame	Falling blocks game	Game	 
CardGame	A card game	Game	 
KidsGame	A game for kids	Game	 
LogicGame	Logic games like puzzles, etc	Game	 
RolePlaying	A roleplaying game	Game	 
Simulation	A simulation game	Game	 
SportsGame	A Sports game	Game	 
StrategyGame	A Strategy game	Game
Comment 5 Nathan Adams 2004-02-17 20:44:49 UTC
From http://freedesktop.org/Standards/menu-spec
"This DRAFT document defines how to construct a user-visible hierarchy of applications, typically displayed as a menu. It allows third-party software to add menu items that work for all desktops, and allows system administrators to edit menus in a way that affects all desktops."

KDE, on the other hand, is PRODUCTION code and uses the more natural "Games" top level menu directory. Can a GNOME user please testify as to the name of their Games top level menu directory?

 
Comment 6 SpanKY gentoo-dev 2004-02-17 20:50:42 UTC
root@vapier 0 kde # pwd
/usr/kde/3.2/share/applications/kde
root@vapier 0 kde # grep Categories.*Game *
KGoldrunner.desktop:Categories=Qt;KDE;Game;ArcadeGame
atlantik.desktop:Categories=Qt;KDE;Game;BoardGame
atlantikdesigner.desktop:Categories=Qt;KDE;Game;BoardGame
kasteroids.desktop:Categories=Qt;KDE;Game;ArcadeGame
katomic.desktop:Categories=Qt;KDE;Game;StrategyGame
kbackgammon.desktop:Categories=Qt;KDE;Game;BoardGame
kbattleship.desktop:Categories=Qt;KDE;Game;StrategyGame
Comment 7 Nathan Adams 2004-02-17 20:56:23 UTC
$ pwd
/usr/kde/3.1/share/applnk
$ ls -l
[snip]
drwxr-xr-x    8 root     root          248 Jan 17 06:39 Games
[snip]

Not everyone is the latest version of KDE.
Comment 8 Chris Gianelloni (RETIRED) gentoo-dev 2004-02-18 05:58:15 UTC
I understand what you're saying, but this has been "fixed" in the most recent version of KDE.  If I were to fix it for your version of KDE, it would break the current version... at least that's how I'm reading it.
Comment 9 Nathan Adams 2004-02-22 12:19:15 UTC
We have two separate ideas being mangled into one.

'Game', as shown in the FreeDesktop spec and Spanky's grep output is a keyword used to define a category. It say that program Foo happens to be a Game (among other things possibly). Specifically, it refers to Foo and not the branch of the menu tree that Foo lives in.

'Games' is the name that is displayed to the end-ser of the *menu branch* that contains the actual links to programs, such as Foo (in my example) and Armyops.

I just emerged KDE 3.2, and my menu branch is STILL named 'Games' not 'Game'. This IS a bug, it SHOULD be fixed.

Chris, did you emerge KDE 3.2 or armyops first? 
Comment 10 SpanKY gentoo-dev 2004-02-22 14:20:22 UTC
this bug is closed because the .desktop is designed in exactly the same way as the current kde .desktop files (thats what my grep output shows)

if you can point out the bug in the creation of the .desktop file, i'll fix it, otherwise i consider this a dead bug in favor of the `domenu` GLEP

or, i'll just take it a step further, and remove the .desktop creation from all games ... i never use menus in a DE so it doesnt affect me personally
Comment 11 Nathan Adams 2004-02-23 19:44:32 UTC
The bug isn't the *creation* of the .desktop file, its the *placement* of the .desktop file.

Expected output:
/usr/share/applnk/Games/armyops.desktop

Actual output:
/usr/share/applnk/Game/armyops.desktop
Comment 12 SpanKY gentoo-dev 2004-02-23 19:53:47 UTC
fixed in cvs then

if no subdir is specified then it'll default to 'Games' for game related apps