Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 265319 - eautoreconf operates on $(pwd), but elibtoolize operates on ${S}
Summary: eautoreconf operates on $(pwd), but elibtoolize operates on ${S}
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All All
: High normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-07 14:44 UTC by Michael Haubenwallner (RETIRED)
Modified: 2013-12-31 16:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Haubenwallner (RETIRED) gentoo-dev 2009-04-07 14:44:24 UTC
Facing a problem with eautoreconf in sys-libs/db in Prefix, because even with libtool-2.2.6, elibtoolize still should apply some patches for AIX.

Thing is, sys-libs/db sets S=${WORKDIR}/${P}/build_unix, but eautoreconf (and elibtoolize) must be run in ${WORKDIR}/${P}/dist.

This is done by:
    cd "${S}"/../dist
    eautoreconf

But in this situation, elibtoolize does not find anything to do, because it does: $(find "${S}" -name 'ltmain.sh').

The easy fix for sys-libs/db now would be:
@@
    cd "${S}"/../dist
-   eautoreconf
+   S="${S}"/../dist eautoreconf

But this doesn't feel too correct, thus not filing against sys-libs/db, but eclasses instead.

Question is:
Should the _ebuild_ set $S for elibtoolize even when called via eautoreconf, or should _eautoreconf_ do that, somehow like this in autotools.eclass:

@@ -115 +115 @@ eautoreconf() {
-       elibtoolize
+       S=${pwd} elibtoolize

Or should elibtoolize be not necessary at all after real libtoolize, and the installed libtool contain all the fixes instead?
But even then this inconsistency should be addressed.
Comment 1 SpanKY gentoo-dev 2009-04-12 07:39:42 UTC
setting S in eautoreconf when running elibtoolize seems like the safest thing to do for now

elibtoolize includes changes/workarounds not appropriate for installed libtool, so elibtoolize is still needed

http://sources.gentoo.org/eclass/autotools.eclass?r1=1.83&r2=1.84