Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 265297 - app-admin/sudo-1.7.0 ./configure poorly handles USE=-ldap
Summary: app-admin/sudo-1.7.0 ./configure poorly handles USE=-ldap
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: High minor (vote)
Assignee: Diego Elio Pettenò (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-07 12:27 UTC by T Chan
Modified: 2009-04-07 19:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
./configure patch (configure.patch,540 bytes, patch)
2009-04-07 12:28 UTC, T Chan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description T Chan 2009-04-07 12:27:17 UTC
With USE=-ldap, the line
    if test ${with_ldap-'no'} != "no"; then
causes ./configure to emit
    checking for getspnam... yes
    ./configure: line 22314: test: !=: unary operator expected
    checking for log file location... /var/log/sudo.log

It is not helped by the check for --with-ldap, which sets with-ldap to "" on the "no" case:
    if test "${with_ldap+set}" = set; then
      withval=$with_ldap; case $with_ldap in
        no)         with_ldap="";;
Comment 1 T Chan 2009-04-07 12:28:01 UTC
Created attachment 187570 [details, diff]
./configure patch

Seems to do the right thing.
Comment 2 T Chan 2009-04-07 12:35:58 UTC
The current version seems to work only because test ${with_ldap-'no'} != "no" happens to fail when with_ldap="" (since it expands to "test" "!=" "no"). It's also the only relevant place that with_ldap is used, so the only functional difference is the error message.

Downgrading to minor because it's not yet a problem, but a bit fragile.
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2009-04-07 19:02:41 UTC
Please don't send patches to configure but rather to configure.ac. Also, this should be directly reported upstream.