265159 – app-cdr/cdrtools link with -lacl even if USE="-acl"

Bug 265159 - app-cdr/cdrtools link with -lacl even if USE="-acl"

Summary: app-cdr/cdrtools link with -lacl even if USE="-acl"

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Gentoo Optical Media project

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2009-04-06 21:59 UTC by Michał Górny
Modified:	2009-04-30 01:17 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Fix the issue (cdrtools-2.01.01-acl.diff,941 bytes, patch) 2009-04-06 22:00 UTC, Michał Górny	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2009-04-06 21:59:38 UTC

When libacl is installed in system, cdrtools link with it even if USE="-acl" is set.

$ readelf -d /usr/lib/libfind.so
[…]
 0x0000000000000001 (NEEDED)             Shared library: [libacl.so.1]
[…]

This looks like a simple Makefile bug, causing libfind to be linked against libacl even when no ACL-dependant code is compiled (mkisofs correctly respects user choice).

The solution is to use LIB_ACL_TEST variable inside libfind/*.mk, like mkisofs/Makefile does.

Comment 1 Michał Górny archtester

2009-04-06 22:00:17 UTC

Created attachment 187499 [details, diff]
Fix the issue

Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2009-04-06 22:26:53 UTC

Please don't CC maintainers/herds yourself. Leave that to the bug-wranglers.

Comment 3 Peter Alfredsen (RETIRED) gentoo-dev

2009-04-30 01:17:01 UTC

+  30 Apr 2009; Peter Alfredsen <loki_val@gentoo.org>
+  files/cdrtools-2.01.01_alpha50-asneeded.patch:
+  Fix as-needed patch to not link against libacl unconditionally, bug
+  265159. Thanks to Michał Górny <web-f13zto@mgorny.alt.pl>.
+