Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 264974 - [PATCH] media-video/vlc uses deprecated QT4_BUILT_WITH_USE
Summary: [PATCH] media-video/vlc uses deprecated QT4_BUILT_WITH_USE
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High QA (vote)
Assignee: Alexis Ballier
URL:
Whiteboard:
Keywords:
: 265067 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-04-05 15:06 UTC by Davide Pesavento
Modified: 2009-04-09 06:52 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch against media-video/vlc-0.9.9 (vlc-0.9.9.ebuild.patch,1.23 KB, patch)
2009-04-05 15:10 UTC, Davide Pesavento (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Davide Pesavento (RETIRED) gentoo-dev 2009-04-05 15:06:08 UTC
QA notice: The QT4_BUILT_WITH_USE functionality is deprecated and
will be removed from future versions of qt4.eclass. Please update
the ebuild to use eapi-2 use dependencies instead.
Comment 1 Davide Pesavento (RETIRED) gentoo-dev 2009-04-05 15:10:29 UTC
Created attachment 187371 [details, diff]
Patch against media-video/vlc-0.9.9

- fix the QA warning
- simplify qt4 dependencies
- avoid unneeded subshells
- fix a typo
Comment 2 Ben de Groot (RETIRED) gentoo-dev 2009-04-05 20:05:51 UTC
Patch is correct. I recommend applying it.
Comment 3 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-04-06 08:39:37 UTC
*** Bug 265067 has been marked as a duplicate of this bug. ***
Comment 4 Alexis Ballier gentoo-dev 2009-04-08 07:54:48 UTC
dont drop the qt-core dep; its needed and preferable not to rely on qt-gui dep
also you forgot the skins deps for qt


besides that, patch applied, thanks
Comment 5 Ben de Groot (RETIRED) gentoo-dev 2009-04-08 16:25:15 UTC
(In reply to comment #4)
> dont drop the qt-core dep; its needed and preferable not to rely on qt-gui dep

As qt-gui has and always will have a hard dependency on qt-core, why do you need an explicit dep on qt-core?
Comment 6 Alexis Ballier gentoo-dev 2009-04-09 06:52:52 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > dont drop the qt-core dep; its needed and preferable not to rely on qt-gui dep
> 
> As qt-gui has and always will have a hard dependency on qt-core, why do you
> need an explicit dep on qt-core?

because it really needs it (it links to it) and i dont like implicit deps