Hi, as nirbeek asked me, i imported patch from upstream (#571145), corrected it , because there is a reject for plugins/media-keys/Makefile.am, and solved the bug, when we try to increase the volume when "Master" is muted. AcmeVolume is now completly working :). The problem was found in gsd-media-keys-manager.c module in do_sound_action function, in the VOLUME_KEY_UP case statement, if the hardware is muted the first if is traited, and we have the volume at 0 so the second if is traited too and volume activated to 6, but the original patches didn't unmuted the hardware, so on the second call ONLY the first if is traited (vol != 0) and nothing happen ==> this is for that reason that the volume was blocked. you'll find in attachment the patch which readd AcVolume support (and works correctly :) ) and the ebuild in version bump to add in the overlay.
Created attachment 187301 [details, diff] Readd AcVolume support + fixs existing problems
Created attachment 187304 [details] ebuild version bump
(In reply to comment #1) > Created an attachment (id=187301) [edit] > Readd AcVolume support + fixs existing problems > Hey, this is cheating, this is the same patch with the Makefile problems fixed :) Where's my fixed patch?!
did you read that i wrote ? :p firstly, what are the bug that you found in this plugin ? expect the volume blocking when the hardware is muted (when the volume is at zero the volume blocked and it was impossible to increase it ) this is the only apparently bug (in use) that i found, so i fixed it (see gsd-media-keys-manager.c do_sound_action function line 751, i added a call to acme_volume_set_mute which solve the problem). what are the other bug ? because the rest seems to be okay for me
Ps: i you want i can clean code, because there are some parts that are not optimal. Explain me why it's necessary to re-write all ? we just need to update or rewrite some parts of code yeah no problem, but rewrite all it's a little absurd no ? ;)
(In reply to comment #5) > Ps: i you want i can clean code, because there are some parts that are not > optimal. Explain me why it's necessary to re-write all ? we just need to update > or rewrite some parts of code yeah no problem, but rewrite all it's a little > absurd no ? ;) > Yeah, just remove everything except gstreamer stuff, and do a general cleanup of the code (reducing ifdefs etc). Upstream says gstreamer was the only thing that was ever properly maintained.
(In reply to comment #6) > Yeah, just remove everything except gstreamer stuff, and do a general cleanup > of the code (reducing ifdefs etc). Upstream says gstreamer was the only thing > that was ever properly maintained. > Also, it'll probably be best to do this on the upstream bug so that they can include it and put it in for 2.26.1 or something.
yeah okay, now you are understandable :) and i'll put my result patch on the upstream bug okay ;)
Created attachment 187617 [details] the new ebuild : removed alsa cflags (unused) , "bump" version
Patch was submitted to the upstream bug, please have a look to it . the patches works perfectly for me, please test it ;) mrpouet
(In reply to comment #10) > Patch was submitted to the upstream bug, please have a look to it . > the patches works perfectly for me, please test it ;) > > mrpouet > Compiles, works, committed, pushed, thanks! :)
