Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 264410 - mail-client/claws-mail-3.7.1: add IMAP specified deletion features
Summary: mail-client/claws-mail-3.7.1: add IMAP specified deletion features
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Christian Faulhammer (RETIRED)
URL: http://colino.net/claws-mail/getpatch...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-31 16:07 UTC by michael higgins
Modified: 2009-07-06 12:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description michael higgins 2009-03-31 16:07:26 UTC
I added a src_unpack() with epatch before src_compile() in the ebuild and so now I have some normal IMAP capability around deletes "expunge" option. Yeah! 

I'd finish it, but IDK how to download a patch from a php script. Can you call wget or something in an ebuild? 

Anyway, you folks can put it on the mirrors, whereas I can't, of course.

Just thought you should know it's a trivial fix, if you haven't done it already. It'd be nice to see a -r1 ebuild in the tree that incorporates this patchset. '-)


Reproducible: Always
Comment 1 Christian Faulhammer (RETIRED) gentoo-dev 2009-03-31 17:53:16 UTC
Is there a schedule for a new release already?  I am reluctant to important such a huge changeset into Portage.  Are there any deep impacts that fix some weird bugs (I use IMAP and am quite happy with it)?
Comment 2 michael higgins 2009-03-31 21:25:39 UTC
(In reply to comment #1)
> Is there a schedule for a new release already? 

I don't know, but that Colin suggested this patch for current users... seems like a useful revision.

> I am reluctant to important
> such a huge changeset into Portage. 

If it applies cleanly to the tarball for me, why wouldn't it for everyone? I mean, sure I'm not a developer, but...

> Are there any deep impacts that fix some
> weird bugs (I use IMAP and am quite happy with it)?

Well, yes... in a way. The "weird bug" is that claws-mail has always, until this patch, not handled IMAP deletion properly. Now it does better, graying the headers out and marking with a red 'x' until expunged. That's IMAP... current behavior is not really as IMAP aware as it could be. If you don't expect it, you don't miss it, is true.

The default is to *keep current behavior*, so there is no impact on the users. You can mask it for testing, right, and no one will use it unless they want it or are running the bleeding edge anyway... again, there is no obvious impact, just new menu items.

The change to the ebuild was trivial. I can't put a patch on the mirrors, so it's a PITA to update if you want it, new ebuild or not, unless you have the patch downloaded automatically. (I don't know how to make an ebuild do that.) 

Anyway, it'll be in the next release, so *I'm* all set for now. If you want to, you could make it available.

If anyone else wants to, they can do it by hand as well, so what can I say?

It's up to y'all, but since you follow the releases so quickly, and the changes needed to the ebuild being so trivial, I thought maybe y'all would want to get this in too. IDK. ;-)

> 

Comment 3 Christian Faulhammer (RETIRED) gentoo-dev 2009-04-01 10:03:38 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > Is there a schedule for a new release already? 
> 
> I don't know, but that Colin suggested this patch for current users... seems
> like a useful revision.
 Yes, right.

> > I am reluctant to important
> > such a huge changeset into Portage. 
> 
> If it applies cleanly to the tarball for me, why wouldn't it for everyone? I
> mean, sure I'm not a developer, but...

 Applying cleanly does not mean, that there are no side effects on functionality or even new and severe bugs.  The bigger the patch, the greater the possibility of that.
 
> Anyway, it'll be in the next release, so *I'm* all set for now. If you want to,
> you could make it available.

 Thanks for your explanation, I will test it, think about it and then possibly import in the tree, this may take some days though.
Comment 4 Christian Faulhammer (RETIRED) gentoo-dev 2009-04-02 17:17:28 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > Is there a schedule for a new release already? 
> 
> I don't know, but that Colin suggested this patch for current users... seems
> like a useful revision.

 After reading more into the issue and having a quick test run, I decided that having a new revision is not worth the work.  Due to a mistake, ppc and alpha have 3.7.1 stable, I want the others to follow in some days and not let ppc and alpha redo all their testing work on a -r1.  As upstream will have it in the next release and the patch set is relatively fresh (that means mostly untested), I will not add it.  Another reason is my limited time and online availability.
 You can put the ebuild into a local overlay, and add the patchset into FILESDIR, thus making it easily available to you.  If you have questions about that, don't hesitate to contact me by email.

Your contributions are always welcome, so don't be sad about this being closed, just keep on reporting.
Comment 5 Christian Faulhammer (RETIRED) gentoo-dev 2009-07-06 12:07:23 UTC
Claws 3.7.2 is in the tree which contains this feature.