Bug 263512 – sys-kernel/vanilla-sources-2.6.28.8 does not build with ocfs2 as modules

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Oleg Gawriloff 2009-03-23 16:26:28 UTC]

During make bzImage modules modules_install I have following error:
  CC      fs/ntfs/logfile.o
  CC      fs/ntfs/quota.o
  CC      fs/ntfs/usnjrnl.o
  LD      fs/ntfs/ntfs.o
  LD      fs/ntfs/built-in.o
  LD      fs/ocfs2/built-in.o
  CC [M]  fs/ocfs2/alloc.o
In file included from fs/ocfs2/alloc.c:42:
fs/ocfs2/journal.h: In function 'ocfs2_begin_ordered_truncate':
fs/ocfs2/journal.h:451: warning: passing argument 1 of 'jbd2_journal_begin_ordered_truncate' from incompatible pointer type
fs/ocfs2/journal.h:451: warning: passing argument 2 of 'jbd2_journal_begin_ordered_truncate' makes integer from pointer without a cast
fs/ocfs2/journal.h:451: error: too many arguments to function 'jbd2_journal_begin_ordered_truncate'
make[2]: *** [fs/ocfs2/alloc.o] Error 1
make[1]: *** [fs/ocfs2] Error 2
make: *** [fs] Error 2

2.6.28.7 and earlier build perfectly.

Reproducible: Always

[Comment 1 Oleg Gawriloff 2009-03-23 16:27:35 UTC]

Created attachment 186011 [details]
kernel config

[Comment 2 Oleg Gawriloff 2009-03-25 08:25:44 UTC]

The same error with sys-kernel/vanilla-sources-2.6.28.9

falcon-cl2 linux # emerge --info
Portage 2.1.6.7 (default/linux/amd64/2008.0/no-multilib, gcc-4.1.2, glibc-2.8_p20080602-r1, 2.6.28.7 x86_64)
=================================================================
System uname: Linux-2.6.28.7-x86_64-Intel-R-_Xeon-R-_CPU_E5310_@_1.60GHz-with-glibc2.2.5
Timestamp of tree: Wed, 25 Mar 2009 02:00:02 +0000
distcc 3.0 x86_64-pc-linux-gnu [enabled]
ccache version 2.4 [enabled]
app-shells/bash:     3.2_p39
dev-lang/python:     2.4.4-r14, 2.5.2-r7
dev-python/pycrypto: 2.0.1-r6
dev-util/ccache:     2.4-r7
dev-util/cmake:      2.4.8
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.63
sys-devel/automake:  1.10.2
sys-devel/binutils:  2.18-r3
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.28-r1
ACCEPT_KEYWORDS="amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=nocona"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-O2 -pipe -march=nocona"
DISTDIR="/usr/portage/distfiles"
FEATURES="ccache distcc distlocks fixpackages parallel-fetch protect-owned sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="ftp://ftp1.telecom.by/admin/gentoo/"
LANG="ru_RU.utf8"
LDFLAGS="-Wl,-O1"
LINGUAS="en ru"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/portage/local/layman/wschlich-testing /usr/local/portage"
SYNC="rsync://ftp1.telecom.by/gentoo-portage"
USE="acl amd64 berkdb bzip2 cli cracklib crypt cups dri fortran gdbm iconv isdnlog midi mmx mudflap ncurses nls nptl nptlonly openmp pam pcre perl pppd python readline reflection session spl sse sse2 ssl sysfs tcpd unicode xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en ru" USERLAND="GNU" VIDEO_CARDS="fbdev glint i810 intel mach64 mga neomagic nv r128 radeon savage sis tdfx trident vesa vga via vmware voodoo"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, FFLAGS, INSTALL_MASK, LC_ALL, MAKEOPTS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 3 Mike Pagano 2009-03-26 12:37:13 UTC]

This has been confirmed upstream and we should soon see patches for the 2.6.28 stable tree that fix this.

http://lkml.org/lkml/2009/3/20/375

[Comment 4 Mike Pagano 2009-04-11 20:25:35 UTC]

Closed by mistake

[Comment 5 Mike Pagano 2009-04-14 00:37:06 UTC]

Created attachment 188277 [details, diff]
Patch to revert commit that broke ocfs2 building on 2.6.28.8

Can you please apply this patch and test?

[Comment 6 Oleg Gawriloff 2009-04-16 10:04:00 UTC]

Patch works perfectly. Thanks.

barzog@falcon-test ~ $ uname -a
Linux falcon-test 2.6.28.9 #1 SMP Thu Apr 16 12:53:08 EEST 2009 x86_64 Intel(R) Xeon(R) CPU E5310 @ 1.60GHz GenuineIntel GNU/Linux

/dev/sdg on /home/apache/D5 type ocfs2 (rw,_netdev,noatime,heartbeat=local)

[Comment 7 Mike Pagano 2009-04-16 11:17:58 UTC]

Thanks for testing

[Comment 8 Mike Pagano 2009-04-16 13:47:56 UTC]

Opening until we get this into gentoo-sources 2.6.28-rX

[Comment 9 Mike Pagano 2009-04-16 20:30:26 UTC]

Released in gentoo-sources-2.6.28-r5