Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 263249 - >=dev-lang/lua-5.1.1-r2 missing emacs use flag
Summary: >=dev-lang/lua-5.1.1-r2 missing emacs use flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Matti Bickel (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 263409
Blocks:
  Show dependency tree
 
Reported: 2009-03-21 13:50 UTC by Marco Paolone
Modified: 2009-09-29 08:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
lua-5.1.4.ebuild (lua-5.1.4.ebuild,2.87 KB, text/plain)
2009-03-21 13:51 UTC, Marco Paolone
Details
lua_emacs.diff (lua_emacs.diff,223 bytes, patch)
2009-03-21 21:38 UTC, Marco Paolone
Details | Diff
Proposed patch for lua-5.1.4-r2.ebuild (lua-5.1.4-r2.ebuild.diff,419 bytes, patch)
2009-09-07 10:28 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marco Paolone 2009-03-21 13:50:44 UTC
dev-lang/lua misses emacs use flag, necessary to install lua-mode package.
Perhaps it's unneeded, but it could be useful ;)

Reproducible: Always
Comment 1 Marco Paolone 2009-03-21 13:51:31 UTC
Created attachment 185735 [details]
lua-5.1.4.ebuild
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2009-03-21 20:53:12 UTC
Please attach diffs when you did changes to an ebuild. That would be much more
handy for our devs.
Comment 3 Marco Paolone 2009-03-21 21:38:12 UTC
Created attachment 185792 [details, diff]
lua_emacs.diff
Comment 4 Matti Bickel (RETIRED) gentoo-dev 2009-03-22 09:43:10 UTC
No, i won't be doing this unless lua-mode gets the keywords lua has. If you're still interested, please coordinate with the emacs team to get app-emacs/lua-mode keyworded like this:
=app-emacs/lua-mode-20071122: alpha amd64 arm hppa ia64 mips ppc64 s390 sh sparc x86 x86-freebsd

Alternativly, get the corresponding arches to mask the emacs use-flag. Without that repoman wouldn't even let me commit such a change.

Reopen this bug if you fixed the issue above, thanks!
Comment 5 Ulrich Müller gentoo-dev 2009-03-22 20:50:17 UTC
I've noticed that lua-5.1.4-r1 now has "emacs" in IUSE, but it looks like the flag has no effect?

(In reply to comment #4)
> If you're still interested, please coordinate with the emacs team to get
> app-emacs/lua-mode keyworded like this:
> =app-emacs/lua-mode-20071122: alpha amd64 arm hppa ia64 mips ppc64 s390 sh
> sparc x86 x86-freebsd

That's bug 263409 now. (We don't need mips since "emacs" is use.masked there.)

(In reply to comment #3)
> Created an attachment (id=185792) [edit]
> lua_emacs.diff

lua-mode should be added to PDEPEND of lua. Otherwise there is a large risk that a circular dependency will be created. We had this problem several times already with Emacs modes for programming languages.

(And in fact, there is the following dependency chain: lua-mode -> emacs -> gtk+ -> cups -> refbase -> php -> net-snmp -> rpm -> lua)
Comment 6 Matti Bickel (RETIRED) gentoo-dev 2009-03-22 20:59:12 UTC
Yeah, i fixed this. I was a bit too fast to implement emacs support ;)
Comment 7 Ulrich Müller gentoo-dev 2009-09-07 10:28:53 UTC
Created attachment 203358 [details, diff]
Proposed patch for lua-5.1.4-r2.ebuild
Comment 8 Ulrich Müller gentoo-dev 2009-09-07 10:29:42 UTC
(In reply to comment #4)
> Reopen this bug if you fixed the issue above, thanks!

Reopening, app-emacs/lua-mode has all necessary keywords.
Comment 9 Ulrich Müller gentoo-dev 2009-09-22 14:11:07 UTC
Any objections if I commit this myself?
Comment 10 Ulrich Müller gentoo-dev 2009-09-29 08:04:54 UTC
Fixed in lua-5.1.4-r2.
Thanks for reporting.