Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 26323 - Updated ebuild for xcdroast-0.98_alpha14 to allow dvd-burning
Summary: Updated ebuild for xcdroast-0.98_alpha14 to allow dvd-burning
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Arcady Genkin (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-08-10 04:29 UTC by Andreas Proschofsky (RETIRED)
Modified: 2003-09-03 17:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xcdroast-0.98_alpha14-r2.ebuild (xcdroast-0.98_alpha14-r2.ebuild,1.64 KB, text/plain)
2003-08-10 04:29 UTC, Andreas Proschofsky (RETIRED)
Details
xcdroast-0.98alpha14-dvd.patch (xcdroast-0.98alpha14-dvd.patch,13.98 KB, patch)
2003-08-10 04:30 UTC, Andreas Proschofsky (RETIRED)
Details | Diff
xcdroast.diff (xcdroast.diff,1.30 KB, patch)
2003-08-10 04:33 UTC, Andreas Proschofsky (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Proschofsky (RETIRED) gentoo-dev 2003-08-10 04:29:14 UTC
This is an update ebuild for xcdroast-0.98_alpha14 which allows dvd-burning, the
necessary patch is from Mandrakes package. Also it includes the patch to fix the
startup problem with cdrools >=2.01alpha17

It compiles fine with "regular" cdrtools but to actually be able to use
dvd-burning you need cdrtools-dvdr for which I have done an updated ebuild also:

http://bugs.gentoo.org/show_bug.cgi?id=26322

Anyway I am not quite sure how to handle dependencies, atm I changed it to
virtual/cdrtools, but with this way users are not told that they have to use
cdrtools-dvdr to be able to burn DVDs. I could also depend on cdrtools-dvdr but
in this way users without a dvd-burner would be confused. Also do we really need
to have two different packages for cdrtools, as they only differ from each other
through one patch, a lot of other packages also use patches by default. Or if
applying the dvd-patch shouldn't be "standard" why not use a new "dvdrw" useflag
(or something like that) for it? 

I think haveing only one cdrtools-package would be easier...

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Andreas Proschofsky (RETIRED) gentoo-dev 2003-08-10 04:29:52 UTC
Created attachment 15845 [details]
xcdroast-0.98_alpha14-r2.ebuild
Comment 2 Andreas Proschofsky (RETIRED) gentoo-dev 2003-08-10 04:30:48 UTC
Created attachment 15847 [details, diff]
xcdroast-0.98alpha14-dvd.patch

Should go to the Filesdir
Comment 3 Andreas Proschofsky (RETIRED) gentoo-dev 2003-08-10 04:33:40 UTC
Created attachment 15848 [details, diff]
xcdroast.diff

DIFF of the changes I did to the ebuild
Comment 4 Lars Weiler (RETIRED) gentoo-dev 2003-09-03 17:31:40 UTC
I applied your patches to xcdroast-0.98_alpha14-r2.

For now I make use of the dvd-USE-flag as it's description for now is "Adds support for DVDs".  Okay many people will have DVD-readers but only a few DVD-writers.  So we should definitively think about a new dvdr-useflag.  This would also stop the second ebuild for cdrtools-dvdr.