Bug 263152 – Thunderbird's ebuild does a bad check on the gcc version

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Francisco Blas Izquierdo Riera (RETIRED) 2009-03-20 18:21:11 UTC]

Thunderbird ebuilds since at least 2.0.0.19 do a bad check on the gcc version in order to disable the stack protection.

Where it says
         # -fstack-protector breaks us
        if gcc-version ge 4 1; then
It should be:
        # -fstack-protector breaks us
        if gcc-version ge "4.1"; then

Also this check shpuld be enabled in the thunderbird-1.5.0.14 ebuild

[Comment 1 Francisco Blas Izquierdo Riera (RETIRED) 2009-03-20 19:22:17 UTC]

I made a mistake, what should be replaced is:
         # -fstack-protector breaks us
        if gcc-version ge 4 1; then
to:
        # -fstack-protector breaks us
        if [[ $(gcc-version | cut -d. -f1) -ge 4 && $(gcc-version | cut -d. -f2) -ge 1 ]]; then

The code specified before won't work.

[Comment 2 Lars Wendler (Polynomial-C) (RETIRED) 2009-03-21 00:59:14 UTC]

Created attachment 185688 [details, diff]
mozilla-thunderbird-2.0.0.21.ebuild.diff

Have a look at toolchain-funcs.eclass. There are already functions for that purpose which should make your cut statements unnecessary. See attached patch.

[Comment 3 Raúl Porcel (RETIRED) 2009-03-21 16:06:11 UTC]

All should be fixed now.