Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 262663 - dev-libs/libowfat make dependant apps segfaults if they use umult64
Summary: dev-libs/libowfat make dependant apps segfaults if they use umult64
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: High normal (vote)
Assignee: Patrick Lauer
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 270144
  Show dependency tree
 
Reported: 2009-03-16 14:12 UTC by Raphaël Droz
Modified: 2009-08-10 14:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Raphaël Droz 2009-03-16 14:12:17 UTC
The current libowfat (0.28) ebuild modifies GNUMakefile this way :
sed -i -e "s:^CFLAGS.*:CFLAGS=-I. ${CFLAGS}:"
But libowfat-0.28/mult/umult64.c expect -fomit-frame-pointer :
"/* WARNING: this only works if compiled with -fomit-frame-pointer */"

The mainstream default GNUMakefile contains this parameter, it should be set whatever the status of -fomit-frame-pointer in gentoo make.conf is.
A (dirty ?) workaround would be to use :
sed -i -e "s:^CFLAGS.*:CFLAGS=-I. ${CFLAGS} -fomit-frame-pointer:"
in the ebuild.

The only dependant app is opentracker which is not yet in the tree.
libowfat correctly compiled, opentracker no more segfault.

Reproducible: Always
Comment 1 Raphaël Droz 2009-03-16 14:14:34 UTC
I should have explicitly add in the title that THIS BUG OCCURS
ONLY IF -fomit-frame-pointer is NOT inside make.conf
Comment 2 Víctor Ostorga (RETIRED) gentoo-dev 2009-08-10 02:50:39 UTC
I don't see the warning you are speaking of in the build log, can you attach the build log?
Comment 3 Raphaël Droz 2009-08-10 12:19:46 UTC
In should have precised that the following warning :
"/* WARNING: this only works if compiled with -fomit-frame-pointer */"
appears in the file libowfat-0.28/mult/umult64.c

That's why the ebuild is wrong to reset all CFLAGS, -fomit-frame-pointer should stay. (but anyway if I remember well, the gentoo guide advice to set it in the make.conf)

From the time of comment #1, notice that libowfat is now masked for remaoval because of #272507 and opentracker is still not in the tree nor in the sunrise overlay.

(In reply to comment #2)
> I don't see the warning you are speaking of in the build log, can you attach
> the build log?
> 

Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2009-08-10 14:54:19 UTC
+  10 Aug 2009; Samuli Suominen <ssuominen@gentoo.org>
+  libowfat-0.28-r1.ebuild:
+  append-flags -fomit-frame-pointer wrt #262663.